Skip to content

[HOLD for payment 2024-03-29] [$500] [Wave Collect] [Ideal Nav] Incorrect animation direction on Wallet and Troubleshooting page #37359

Closed
Closed
[HOLD for payment 2024-03-29] [$500] [Wave Collect] [Ideal Nav] Incorrect animation direction on Wallet and Troubleshooting page#37359
Assignees
allroundexpertsmountinykadiealexanderallgandalf
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Description

@lanitochka17
lanitochka17
opened on Feb 27, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.44-7
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause -Internal Team
Slack conversation:

Issue found when executing PR #37078

Action Performed:

Pre-requisite: user must be logged in and have an Expensify card assigned

  1. Go to Settings > Wallet

  2. Tap on Expensify card

  3. Tap on the back button

  4. Tap on the avatar to open the account settings

  5. Tap about

  6. Tap troubleshoot

  7. Then Tap <until you reach LHN

  8. Observe the sliding behavior

Expected Result:

A transition animation from left to right should appear (going back to previous page)

Opening each page account settings, about and troubleshootshould slige from the right overtop of the previous page and When pressing < button the page should slide away to the right

Actual Result:

A transition animation from right to left appears (as if it were a new page, not a previous one)

When pressing back button Troubleshoot page, About page slides in from the right, again, overtop Troubleshoot
Similarly pressing back button again, Profile slides in from the right
Finally, pressing back button, Account Settings slides away to the right which is the correct behavior

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6394726_1709070563566.Slts0498_1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01588c7a6a3b8f24cb
  • Upwork Job ID: 1762991723171692544
  • Last Price Increase: 2024-03-12
Issue OwnerCurrent Issue Owner: @allroundexperts

Activity

  1. lanitochka17
    added
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 27, 2024

  2. melvin-bot commented on Feb 27, 2024

    @melvin-bot
    melvin-botbot
    on Feb 27, 2024 – with Melvin Bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot
    assigned
    kadiealexander
    on Feb 27, 2024

  4. lanitochka17 commented on Feb 27, 2024

    @lanitochka17
    lanitochka17
    on Feb 27, 2024
    Author

    @kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  5. apeyada commented on Feb 28, 2024

    @apeyada
    apeyada
    on Feb 28, 2024
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Wallet - When going back to Wallet from Expensify card, animation goes from right lo left

    What is the root cause of that problem?

    App/src/pages/settings/Wallet/ExpensifyCardPage.tsx

    Line 127 in 4fcfbb0

    onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_WALLET)}

    App/src/pages/settings/Wallet/ExpensifyCardPage.tsx

    Line 115 in 4fcfbb0

    return <NotFoundPage onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_WALLET)} />;

    Here, we go to wallet page using goback(ROUTES.SETTINGS_WALLET)
    This now became issue after ideal nav.

    What changes do you think we should make in order to solve the problem?

    As wallet page is already in center pane, it's fine to navigate goBack without param even when deeplink to this page and click back button

    App/src/pages/settings/Wallet/ExpensifyCardPage.tsx

    Line 127 in 4fcfbb0

    onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_WALLET)}

    onBackButtonPress={() => Navigation.goBack()}
    or we can remove this line as it's already default prop value in HeaderWithBackButton

    App/src/pages/settings/Wallet/ExpensifyCardPage.tsx

    Line 115 in 4fcfbb0

    return <NotFoundPage onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_WALLET)} />;

    onBackButtonPress={() => Navigation.goBack()}

    (optional)
    use FullPageNotFoundView instead of early returning NotFoundPage when isNotFound

  6. kadiealexander
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 29, 2024

  7. melvin-bot commented on Feb 29, 2024

    @melvin-bot
    melvin-botbot
    on Feb 29, 2024 – with Melvin Bot

    Job added to Upwork: https://www.upwork.com/jobs/~01588c7a6a3b8f24cb

  8. melvin-bot
    changed the title [-]Wallet - When going back to Wallet from Expensify card, animation goes from right lo left[/-] [+][$500] Wallet - When going back to Wallet from Expensify card, animation goes from right lo left[/+] on Feb 29, 2024
  9. melvin-bot
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 29, 2024
  10. melvin-bot
    assigned
    Santhosh-Sellavel
    on Feb 29, 2024

  11. melvin-bot commented on Feb 29, 2024

    @melvin-bot
    melvin-botbot
    on Feb 29, 2024 – with Melvin Bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

  12. melvin-bot
    added
    Overdue
    on Mar 4, 2024

  13. Santhosh-Sellavel commented on Mar 4, 2024

    @Santhosh-Sellavel
    Santhosh-Sellavel
    on Mar 4, 2024
    Collaborator

    Back from OOO Will update in a day.

  14. melvin-bot
    removed
    Overdue
    on Mar 4, 2024

  15. 59 remaining items

  16. kadiealexander
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Apr 3, 2024

  17. allgandalf commented on Apr 3, 2024

    @allgandalf
    allgandalf
    on Apr 3, 2024
    Contributor

    @GandalfGwaihir I can't find you on Upwork, can you please apply here?

    Applied just now, can you check please :)

  18. kadiealexander commented on Apr 4, 2024

    @kadiealexander
    kadiealexander
    on Apr 4, 2024
    Contributor

    Offer sent :)

  19. allgandalf commented on Apr 4, 2024

    @allgandalf
    allgandalf
    on Apr 4, 2024 via email
    Contributor

  20. melvin-bot commented on Apr 8, 2024

    @melvin-bot
    melvin-botbot
    on Apr 8, 2024 – with Melvin Bot

    @allroundexperts, @mountiny, @kadiealexander, @GandalfGwaihir Huh... This is 4 days overdue. Who can take care of this?

  21. melvin-bot
    added
    Overdue
    on Apr 8, 2024

  22. kadiealexander commented on Apr 9, 2024

    @kadiealexander
    kadiealexander
    on Apr 9, 2024
    Contributor

    @allroundexperts please complete the checklist so we can get this closed out.

  23. melvin-bot
    removed
    Overdue
    on Apr 9, 2024

  24. allroundexperts commented on Apr 10, 2024

    @allroundexperts
    allroundexperts
    on Apr 10, 2024
    Contributor

    On it today.

  25. allroundexperts commented on Apr 11, 2024

    @allroundexperts
    allroundexperts
    on Apr 11, 2024
    Contributor

    Checklist

    1. There isn't a single PR which introduced this. I think over the time, we were just following the same pattern, and as a result we had a bunch of pages with similar problem.
    2. N/A
    3. N/A
    4. A regression test would be useful. The steps mentioned un the OP look good enough to me!
  26. kadiealexander
    closed this as completedon Apr 15, 2024
  27. github-project-automation
    moved this from Polish to Done in [#whatsnext] #wave-collecton Apr 15, 2024

  28. kadiealexander commented on Apr 15, 2024

    @kadiealexander
    kadiealexander
    on Apr 15, 2024
    Contributor

    Payment summary here.

  29. JmillsExpensify commented on Apr 30, 2024

    @JmillsExpensify
    JmillsExpensify
    on Apr 30, 2024
    Contributor

    $500 approved for @allroundexperts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions