Repository navigation
[HOLD for payment 2024-03-14] Gesture to hide the search page should be right to left #37354
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.43-14
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @youssef-lr
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1709024846036369
Action Performed:
- Open the search page
- Use gesture to hide the page swiping left to right
- Observe the animation
Expected Result:
The gesture to hide a page that opens from left to right should be a swipe from right to left OR
The search page & workspace switcher use the same direction of the profile page.
Actual Result:
We use the gesture left to right to close the "search" but the animation is from right to left
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
RPReplay_Final1709067741.MP4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01ac67e098881d1f63
- Upwork Job ID: 1762586657702166528
- Last Price Increase: 2024-02-27
Activity
melvin-bot commentedon Feb 27, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01ac67e098881d1f63
[-]Gesture to hide the search page should be right to left [/-][+][$500] Gesture to hide the search page should be right to left [/+]melvin-bot commentedon Feb 27, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (
External)melvin-bot commentedon Feb 27, 2024
Triggered auto assignment to @twisterdotcom (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.twisterdotcom commentedon Feb 27, 2024
Weird react navigation bug I assume. We should match the animation.
youssef-lr commentedon Feb 27, 2024
I think @kirillzyusko is looking into this
38 remaining items
melvin-bot commentedon Mar 7, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
melvin-bot commentedon Mar 14, 2024
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
twisterdotcom commentedon Mar 14, 2024
No payment necessary here. @youssef-lr do we ned a test case at all? Gonna close, but if you think we do, lay out the steps and I'll create one.
youssef-lr commentedon Mar 14, 2024
Nah I don't think we do.