Skip to content

[HOLD for payment 2024-03-20] [$500][MEDIUM] Categories: Parent that has own category is not ticked in All list when selected #37326

Closed
Closed
[HOLD for payment 2024-03-20] [$500][MEDIUM] Categories: Parent that has own category is not ticked in All list when selected#37326
Assignees
hoangzinhblimpichjoekaufmanexpensifydukenv0307
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Description

@lanitochka17
lanitochka17
opened on Feb 27, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.44-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition:

  • User is an employee of Collect workspace
  • The Collect workspace has these categories:
  • Test
  • Test: Test 1
  • Test: Test 2
  1. Go to staging.new.expensify.com
  2. Go to workspace chat
  3. Click + > Request money > Manual
  4. Enter amount and proceed to confirmation page
  5. Click Show more
  6. Click Category
  7. Select the parent category "Test"
  8. Click Category
  9. Scroll down to find the parent category "Test"

Expected Result:

The parent category "Test" will be displayed with a tick in the list (production behavior) because it is selected

Actual Result:

The parent category "Test" is not displayed with a tick in the list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6394349_1709055194859.20240227-135357_a31RC8Aq.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010569839356f2354c
  • Upwork Job ID: 1762533897677324288
  • Last Price Increase: 2024-02-27
  • Automatic offers:
    • hoangzinh | Reviewer | 0
    • dukenv0307 | Contributor | 0

Activity

  1. lanitochka17
    added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 27, 2024
  2. melvin-bot
    changed the title [-]Category - Parent that has own category is not ticked in All list when selected[/-] [+][$500] Category - Parent that has own category is not ticked in All list when selected[/+] on Feb 27, 2024

  3. melvin-bot commented on Feb 27, 2024

    @melvin-bot
    melvin-botBot
    on Feb 27, 2024 – with Melvin Bot

    Job added to Upwork: https://www.upwork.com/jobs/~010569839356f2354c

  4. melvin-bot
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 27, 2024

  5. melvin-bot commented on Feb 27, 2024

    @melvin-bot
    melvin-botBot
    on Feb 27, 2024 – with Melvin Bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

  6. melvin-bot
    assigned
    hoangzinh
    on Feb 27, 2024
  7. melvin-bot
    added
    DailyKSv2
    on Feb 27, 2024
  8. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Feb 27, 2024

  9. github-actions commented on Feb 27, 2024

    @github-actions
    github-actionsBot
    on Feb 27, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  10. melvin-bot
    assigned
    blimpich
    on Feb 27, 2024

  11. melvin-bot commented on Feb 27, 2024

    @melvin-bot
    melvin-botBot
    on Feb 27, 2024 – with Melvin Bot

    Triggered auto assignment to @blimpich (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  12. lanitochka17 commented on Feb 27, 2024

    @lanitochka17
    lanitochka17
    on Feb 27, 2024
    Author

    We think that this bug might be related to #wave6
    CC @greg-schroeder

  13. 49 remaining items

  14. joekaufmanexpensify commented on Mar 18, 2024

    @joekaufmanexpensify
    joekaufmanexpensify
    on Mar 18, 2024
    Contributor

    @hoangzinh could you please handle checklist so we can prep to issue payment?

  15. hoangzinh commented on Mar 19, 2024

    @hoangzinh
    hoangzinh
    on Mar 19, 2024
    Contributor

    @joekaufmanexpensify @blimpich Because this is a DB, could you someone please check if we already have a regression test for it? Otherwise, I will propose a new one.

  16. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Mar 20, 2024

  17. joekaufmanexpensify commented on Mar 20, 2024

    @joekaufmanexpensify
    joekaufmanexpensify
    on Mar 20, 2024
    Contributor

    @hoangzinh the scope of this issue only impacts sub-categories, correct? If so, I think this is a pretty niche case, and a regression test for every run is probably not needed.

  18. hoangzinh commented on Mar 20, 2024

    @hoangzinh
    hoangzinh
    on Mar 20, 2024
    Contributor

    the scope of this issue only impacts sub-categories, correct?

    Yes it's correct. Do you mean this issue is an edge case and we don't need a regression test for it?

  19. joekaufmanexpensify commented on Mar 21, 2024

    @joekaufmanexpensify
    joekaufmanexpensify
    on Mar 21, 2024
    Contributor

    Yep, that's correct. Could you please do the rest of the checklist? And then I'll issue payment.

  20. hoangzinh commented on Mar 21, 2024

    @hoangzinh
    hoangzinh
    on Mar 21, 2024
    Contributor

    BugZero Checklist:

    • The PR that introduced the bug has been identified. Link to the PR: 20354 category picker list refactor #35567
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/35567/files#r1534051972
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • Determine if we should create a regression test for this bug: ❌ It's an edge case and we don't need a regression test for it.

  21. joekaufmanexpensify commented on Mar 21, 2024

    @joekaufmanexpensify
    joekaufmanexpensify
    on Mar 21, 2024
    Contributor

    TY! All set to issue payment. We need to pay:

  22. joekaufmanexpensify commented on Mar 21, 2024

    @joekaufmanexpensify
    joekaufmanexpensify
    on Mar 21, 2024
    Contributor

    @hoangzinh $500 sent and contract ended!

  23. joekaufmanexpensify commented on Mar 21, 2024

    @joekaufmanexpensify
    joekaufmanexpensify
    on Mar 21, 2024
    Contributor

    @dukenv0307 $500 sent and contract ended!

  24. joekaufmanexpensify commented on Mar 21, 2024

    @joekaufmanexpensify
    joekaufmanexpensify
    on Mar 21, 2024
    Contributor

    Upwork job closed.

  25. joekaufmanexpensify commented on Mar 21, 2024

    @joekaufmanexpensify
    joekaufmanexpensify
    on Mar 21, 2024
    Contributor

    All set, thanks everyone!

  26. joekaufmanexpensify
    closed this as completedon Mar 21, 2024
  27. github-project-automation
    moved this from Polish to Done in [#whatsnext] #wave-collecton Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions