Skip to content

[HOLD for payment 2024-03-18] [$500] Still can access to Tag page when request money to DM 1:1 chat #37207

Closed
Closed
[HOLD for payment 2024-03-18] [$500] Still can access to Tag page when request money to DM 1:1 chat#37207
Assignees
jasperhuangglschurrmkhutornyiDylanDylann
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Description

@m-natarajan
m-natarajan
opened on Feb 26, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.43-15
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @DylanDylann
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1708850630563619

Action Performed:

  1. Request money
  2. Enter amount
  3. Select DM 1:1 chat
  4. Click on description page
  5. In the URL, change description to category or tag/1
    (on native app or desktop app, using deeplink)

Expected Result:

Should display Not Found Page

Actual Result:

Empty category/tag page display

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screen.Recording.2024-02-25.at.15.40.13.mov

View all open jobs on GitHub

Recording.2778.mp4
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019d915d40b791c907
  • Upwork Job ID: 1762132134901731328
  • Last Price Increase: 2024-02-26
  • Automatic offers:
    • mkhutornyi | Reviewer | 0
    • DylanDylann | Contributor | 0

Activity

  1. m-natarajan
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 26, 2024
  2. melvin-bot
    changed the title [-]Still can access to Tag page when request money to DM 1:1 chat[/-] [+][$500] Still can access to Tag page when request money to DM 1:1 chat[/+] on Feb 26, 2024

  3. melvin-bot commented on Feb 26, 2024

    @melvin-bot
    melvin-botBot
    on Feb 26, 2024 – with Melvin Bot

    Job added to Upwork: https://www.upwork.com/jobs/~019d915d40b791c907

  4. melvin-bot
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 26, 2024
  5. melvin-bot
    assigned
    mkhutornyi
    on Feb 26, 2024

  6. melvin-bot commented on Feb 26, 2024

    @melvin-bot
    melvin-botBot
    on Feb 26, 2024 – with Melvin Bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)

  7. melvin-bot
    assigned
    lschurr
    on Feb 26, 2024

  8. melvin-bot commented on Feb 26, 2024

    @melvin-bot
    melvin-botBot
    on Feb 26, 2024 – with Melvin Bot

    Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  9. DylanDylann commented on Feb 26, 2024

    @DylanDylann
    DylanDylann
    on Feb 26, 2024
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Still can access to Tag page when request money to DM 1:1 chat

    What is the root cause of that problem?

    In IOURequestStepTag we don't pass shouldShowNotFoundPage props to StepScreenWrapper

    What changes do you think we should make in order to solve the problem?

    In IOURequestStepTag we should pass shouldShowNotFoundPage props to StepScreenWrapper

        const shouldShowNotFoundPage = !isPolicyExpenseChat || (!transactionTag && !OptionsListUtils.hasEnabledTags(policyTagLists)));

    App/src/pages/EditRequestPage.js

    Line 158 in 6cd008e

    if (fieldToEdit === CONST.EDIT_REQUEST_FIELD.TAG && shouldShowTags) {

    Like we did here

    App/src/pages/EditRequestPage.js

    Line 92 in 6cd008e

    const shouldShowTags = useMemo(() => isPolicyExpenseChat && (transactionTag || OptionsListUtils.hasEnabledTags(policyTagLists)), [isPolicyExpenseChat, policyTagLists, transactionTag]);

    What alternative solutions did you explore? (Optional)

  10. melvin-bot
    added
    Overdue
    on Feb 28, 2024

  11. lschurr commented on Feb 28, 2024

    @lschurr
    lschurr
    on Feb 28, 2024
    Contributor

    Could you review this one @mkhutornyi?

  12. melvin-bot
    removed
    Overdue
    on Feb 28, 2024

  13. mkhutornyi commented on Feb 28, 2024

    @mkhutornyi
    mkhutornyi
    on Feb 28, 2024 · Hidden as resolved

  14. 16 remaining items

  15. DylanDylann commented on Mar 5, 2024

    @DylanDylann
    DylanDylann
    on Mar 5, 2024
    Contributor

    @mkhutornyi The PR is ready for review: #37747

  16. melvin-bot
    added
    WeeklyKSv2
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    WeeklyKSv2
    on Mar 11, 2024
  17. melvin-bot
    changed the title [-][$500] Still can access to Tag page when request money to DM 1:1 chat[/-] [+][HOLD for payment 2024-03-18] [$500] Still can access to Tag page when request money to DM 1:1 chat[/+] on Mar 11, 2024
  18. melvin-bot
    removed
    ReviewingHas a PR in review
    on Mar 11, 2024

  19. melvin-bot commented on Mar 11, 2024

    @melvin-bot
    melvin-botBot
    on Mar 11, 2024 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  20. melvin-bot commented on Mar 11, 2024

    @melvin-bot
    melvin-botBot
    on Mar 11, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.49-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-03-18. 🎊

    For reference, here are some details about the assignees on this issue:

  21. melvin-bot commented on Mar 11, 2024

    @melvin-bot
    melvin-botBot
    on Mar 11, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@mkhutornyi / @DylanDylann] The PR that introduced the bug has been identified. Link to the PR:
    • [@mkhutornyi / @DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@mkhutornyi / @DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@mkhutornyi / @DylanDylann] Determine if we should create a regression test for this bug.
    • [@mkhutornyi / @DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  22. lschurr commented on Mar 14, 2024

    @lschurr
    lschurr
    on Mar 14, 2024
    Contributor

    Could you work on the checklist for this one @mkhutornyi?

  23. mkhutornyi commented on Mar 14, 2024

    @mkhutornyi
    mkhutornyi
    on Mar 14, 2024
    Contributor
    1. The PR that introduced the bug has been identified. Link to the PR: Fix - An employee can access in a paid IOU the tag selection menu via a URL request #37176
    2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/37176/files#r1525400140
    3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    4. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. Yes
    5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Proposal:

    1. FAB > Request money
    2. Enter any amount
    3. Select DM 1:1 chat
    4. Click on description page
    5. In the URL, change description to category or tag/1
    6. Verify that not found page shows
  24. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Mar 17, 2024

  25. lschurr commented on Mar 18, 2024

    @lschurr
    lschurr
    on Mar 18, 2024
    Contributor

    Payment summary:

  26. lschurr
    closed this as completedon Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions