Repository navigation
[HOLD for payment 2024-03-13] [Wave8] [Simplified Collect] [Workflows] Create Approval page #37195
Description
We've recently merged the main workflows page.
The task here is to create the Approval page present under the main worfklows page.
It will appear when we click on the > icon under the Add approval menu item:
Expected mockup below:
Technical details can be found here.
Activity
melvin-bot commentedon Feb 26, 2024
Triggered auto assignment to @trjExpensify (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.lakchote commentedon Feb 27, 2024
@rushatgabhane will be doing the implementation.
Assigning @allroundexperts as the reviewer.
For context please see discussion here
trjExpensify commentedon Feb 27, 2024
Wahoo! Let's do it.
rushatgabhane commentedon Feb 27, 2024
Discussion here for real time - https://expensify.slack.com/archives/C02NK2DQWUX/p1709028046898869?thread_ts=1709017652.394349&cid=C02NK2DQWUX
13 remaining items
melvin-bot commentedon Mar 6, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 6, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.47-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-03-13. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 6, 2024
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
allroundexperts commentedon Mar 8, 2024
I feel like this should have double the bounty since this was a feature that took much more time than what a normal bug would take to fix. What do you think @rushatgabhane?
luacmartins commentedon Mar 11, 2024
Sure, I think that's fair in this case. cc @trjExpensify
rushatgabhane commentedon Mar 11, 2024
I'm happy with $500 because the implementation was straightforward. But ofcourse, double pay would make me very happy 😆
luacmartins commentedon Mar 12, 2024
We discussed this internally with the team and we'll keep the bounty at $500 for this one. We understand that there'll inevitably be differences between the level of effort required for each issue, but we think that the current bounty is pretty generous across the board. We appreciate you both working on high value items like this one.
melvin-bot commentedon Mar 13, 2024
Payment Summary
Upwork Job
BugZero Checklist (@trjExpensify)
trjExpensify commentedon Mar 14, 2024
Confirming the payment summary is correct. Both of you can go ahead and request on NewDot. Closing!
JmillsExpensify commentedon Apr 1, 2024
$500 approved for @allroundexperts
JmillsExpensify commentedon Apr 3, 2024
$500 approved for @rushatgabhane