Repository navigation
[HOLD for payment 2024-03-07] Hold dot separator doesn’t show in the expense preview #36977
Description
Activity
Triggered auto assignment to @twisterdotcom (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.@robertjchen Eep! 4 days overdue now. Issues have feelings too...
Finalizing PR
- changed the title
[-]Hold dot separator doesn’t show in the expense preview[/-][+][HOLD for payment 2024-03-07] Hold dot separator doesn’t show in the expense preview[/+]on Feb 29, 2024 Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-03-07. 🎊
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@robertjchen] The PR that introduced the bug has been identified. Link to the PR:
- [@robertjchen] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@robertjchen] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@robertjchen] Determine if we should create a regression test for this bug.
- [@robertjchen] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
C+ payment is pending here
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
cc: @twisterdotcom for assistance on #36977 (comment) Thanks! 🙏
Action Performed:
Go to Expense preview for held request
Expected Result:
Actual Result:
Workaround:
N/A
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
See above
View all open jobs on GitHub