Repository navigation
[Payment due March 7] [Performance] Remove cache from the getOrderedReportIDs method #36799
Description
Coming from Slack
Problem
Whenever we want to calculate order of reports in the LHN, the getOrderedReportIDs function is called. Based on our investigations for different metrics (Report load time and Send a message), we can tell that the getOrderedReportIDs is a main bottleneck responsible for app's degrading performance.
Details can be found in the Cache part of this analysis
### Solution
In order to fix the underlying issue, we have splitted the implementation into a few atomic PRs that could be easily digested. One of them is presented below.
Followed the analysis, the overhead that stems from cache lookup when generating ordered reports does not match its possible positive outcomes on overall time execution. Analysis, as well as, measurements with possible gains of removing the cache are presented in linked issues.
Metadata
Metadata
Type
Projects
- Status
Activity
kacper-mikolajczak commentedon Feb 19, 2024
Hi @mountiny
melvin-bot commentedon Feb 26, 2024
@mountiny, @kacper-mikolajczak Whoops! This issue is 2 days overdue. Let's get this updated quick!
mountiny commentedon Feb 26, 2024
Merged
melvin-bot commentedon Mar 5, 2024
@mountiny, @kacper-mikolajczak Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Mar 5, 2024
@mountiny, @kacper-mikolajczak Whoops! This issue is 2 days overdue. Let's get this updated quick!
jjcoffee commentedon Mar 7, 2024
I am due payment for the PR review on this. Deployed to production last week so should be due payment today, I think. 🙇
melvin-bot commentedon Mar 7, 2024
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.[-][Performance] Remove cache from the getOrderedReportIDs method[/-][+][Payment due March 7] [Performance] Remove cache from the getOrderedReportIDs method[/+]Christinadobrzyn commentedon Mar 8, 2024
Payouts due:
Contributor+: $500 @jjcoffee (in Upwork - offer sent - https://www.upwork.com/nx/wm/offer/101274490
Upwork job is here.
sent you an offer @jjcoffee!
jjcoffee commentedon Mar 8, 2024
@Christinadobrzyn Accepted, thanks! 🙇
Christinadobrzyn commentedon Mar 8, 2024
Awesome! Paid to you @jjcoffee based on this payment summary #36799 (comment)
Closing