Repository navigation
[No BZ] Warn developers if they upgrade a dependency but not a patch #36776
Description
Coming from #36775...
Problem
When upgrading dependencies, it's possible that you may break a patch for that dependency. It's also possible that the patch may no longer be needed. It's easy to forget this, which leaves unused patch files in our repo.
Solution
Add a simple PR check to our webhook that looks for PRs that upgrade a dependency with a patch without updating the patch and include a PR comment like:
Heads up! It looks like you updated a dependency without updating the patch. Do you need to update the patch?
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~019999ca1782dc1db6
- Upwork Job ID: 1759309916923375616
- Last Price Increase: 2024-02-18
Activity
melvin-bot commentedon Feb 18, 2024
Triggered auto assignment to @puneetlath (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.melvin-bot commentedon Feb 18, 2024
Job added to Upwork: https://www.upwork.com/jobs/~019999ca1782dc1db6
melvin-bot commentedon Feb 18, 2024
Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane (
Internal)roryabraham commentedon Feb 18, 2024
I was thinking this should be internal like other similar-style warnings in our webhook. Don't need a C+, not sure why we assign them for issues labelled
Internal...3 remaining items
[-]Warn developers if they upgrade a dependency but not a patch[/-][+][No BZ] Warn developers if they upgrade a dependency but not a patch[/+]mallenexpensify commentedon Apr 4, 2024
Updated title to denote this
NewFeaturedoesn't need a BZ assigned.roryabraham commentedon Apr 15, 2024
This also isn't really in the roadmap anywhere - it's more of an automation to prevent developer mistakes
melvin-bot commentedon Jun 27, 2024
@roryabraham, this Monthly task hasn't been acted upon in 6 weeks; closing.
If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.
roryabraham commentedon Jun 28, 2024
This was quick and easy to implement, and failing to correctly update our patches can lead to headaches. So I created a PR to add this check. It's all-too-common for patches to be added with limited context and then basically left forever, so hopefully this should help curb that practice.
melvin-bot commentedon Aug 26, 2024
@roryabraham, this Monthly task hasn't been acted upon in 6 weeks; closing.
If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.
roryabraham commentedon Aug 26, 2024
oh, this has been done for a while 🙈