[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] Context Menu and hover menu is visible on message being Edited

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open any conversation on E.cash
Click Edit message from the context menu on any message.
Now right click on the message being edited or hover over it.

Expected Result:

Context & hover menu is not visible on the already edited message.

Actual Result:

Context menu & hover menu is visible on the message being edited.

Workaround:

None It. It is unexpected behavior. For eg., you can delete a message being edited.

Platform:

Where is this issue occurring?

Web - ✔️
iOS - ✔️
Android - ✔️
Desktop App - ✔️
Mobile Web - ✔️

Version Number: 1.0.71-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

menu-issue.mp4

Expensify/Expensify Issue URL:

View all open jobs on Upwork

@alexpensify

Triggered auto assignment to @alexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

Proposal

We need to block the context menu by adding a condition here https://github.com/Expensify/Expensify.cash/blob/baba3b9c129f054b3adc92579f6f270854832edb/src/pages/home/report/ReportActionItem.js#L167

    if (this.props.draftMessage) {
            return;
        }

then to block the hover menu here https://github.com/Expensify/Expensify.cash/blob/baba3b9c129f054b3adc92579f6f270854832edb/src/pages/home/report/ReportActionItem.js#L261

 isVisible={ hovered  && !this.state.isPopoverVisible && !this.props.draftMessage }

@bondydaa

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@jboniface

Triggered auto assignment to @jboniface (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Reviewing label has been removed, please complete the "BugZero Checklist".

@parasharrajat

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[No QA] Fail patch-package on errors or warnings #44589

If no regressions arise, payment will be issued on 2024-07-17. 🎊

For reference, here are some details about the assignees on this issue:

@parasharrajat requires payment through NewDot Manual Requests
@jboniface requires payment (Needs manual offer from BZ)

@parasharrajat

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[No QA] Fail patch-package on errors or warnings #44589

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

@parasharrajat requires payment through NewDot Manual Requests
@jboniface requires payment (Needs manual offer from BZ)

Navigation Menu

Repository navigation

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] Context Menu and hover menu is visible on message being Edited #3677

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platform:

Proposal

11 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] Context Menu and hover menu is visible on message being Edited #3677

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platform:

Activity

MelvinBot commented on Jun 18, 2021

parasharrajat commented on Jun 18, 2021

Proposal

MelvinBot commented on Jun 18, 2021

MelvinBot commented on Jun 18, 2021

11 remaining items

melvin-bot commented on Jul 10, 2024

melvin-bot commented on Jul 10, 2024

melvin-bot commented on Jul 15, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions