Skip to content

[HOLD for payment 2024-03-22] [$1000] Settings - Performance and heat issues on the "Troubleshoot" option #36645

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found when executing #35306
Version Number: 1.4.42.0
Reproducible in staging?: y
Reproducible in production?: New feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Navigate to Account settings - About - Troubleshoot
  2. Background the app
  3. Foreground the app
  4. Swipe up and down

Expected Result:

Swiping should be smooth. The phone shouldn't heat up or crash.

Actual Result:

Low performance when I foreground the app. The phone heats up if I stay on the page. It even crashed once.
The issue disappears if I navigate back and to the "Troubleshoot" again.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6381225_1708030928625.20240215_185611.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01dd3351f4b07d85c0
  • Upwork Job ID: 1758255599540744192
  • Last Price Increase: 2024-02-27

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 15, 2024
  2. changed the title [-]Settings - Performance and heat issues on the "Troubleshoot" option[/-] [+][$500] Settings - Performance and heat issues on the "Troubleshoot" option[/+] on Feb 15, 2024
  3. melvin-bot commented on Feb 15, 2024

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 15, 2024
  5. melvin-bot commented on Feb 15, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

  6. melvin-bot commented on Feb 15, 2024

    @melvin-bot

    Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  7. github-actions commented on Feb 15, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. 88 remaining items

  9. ikevin127 commented on Mar 13, 2024

    @ikevin127
    Contributor

    Accepted, thank you!

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 15, 2024
  11. changed the title [-][$1000] Settings - Performance and heat issues on the "Troubleshoot" option[/-] [+][HOLD for payment 2024-03-22] [$1000] Settings - Performance and heat issues on the "Troubleshoot" option[/+] on Mar 15, 2024
  12. melvin-bot commented on Mar 15, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Mar 15, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.52-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-03-22. 🎊

    For reference, here are some details about the assignees on this issue:

    • @hoangzinh requires payment (Needs manual offer from BZ)
    • @ikevin127 requires payment (Needs manual offer from BZ)
  14. melvin-bot commented on Mar 15, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@hoangzinh] The PR that introduced the bug has been identified. Link to the PR:
    • [@hoangzinh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@hoangzinh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@hoangzinh] Determine if we should create a regression test for this bug.
    • [@hoangzinh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  15. ikevin127 commented on Mar 22, 2024

    @ikevin127
    Contributor

    @mallenexpensify All good for payment here ?

  16. mallenexpensify commented on Mar 23, 2024

    @mallenexpensify
    Contributor

    Contributor: @ikevin127 paid $1000 via Upwork
    Contributor+: @hoangzinh paid $1000 via Upwork.

    @hoangzinh plz fill out the BZ checklist above.

    Thx!

  17. hoangzinh commented on Mar 23, 2024

    @hoangzinh
    Contributor

    BugZero Checklist:

    • The PR that introduced the bug has been identified. Link to the PR: feat: Troubleshooting page & resetting Onyx state #35306
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: feat: Troubleshooting page & resetting Onyx state #35306 (comment)
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • Determine if we should create a regression test for this bug: ❌ I think it's an edge case and just performance improvement. Moreover, We gonna move "Troubleshoot" out of "About" setting here, so it avoids 2 Lotties animation.
  18. mallenexpensify commented on Mar 25, 2024

    @mallenexpensify
    Contributor

    Thanks @hoangzinh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions