[$500] Domain Card - User can edit the date in expenses related to the assigned domain card

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.42-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): tester+domaincard@applausecard.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Open App or go to staging.new.expensify.com
2. Log in with tester+domaincard@applausecard.expensifail.com
3. Navigate to the workspace chat for "Domain Card tests - DO NOT DELETE"
4. Verify there's a report that contains the expenses related to the assigned domain card
5. Click on the report
6. Verify you can see the individual expenses
7. Click on a individual expense
8. Verify the fields "Amount" and "Date" are not editable

Expected Result:

Fields "Amount" and "Date" are not editable

Actual Result:

User has access to edit the date.
(User receives an error after editing the date, but can try to do it)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6380969_1708019494480.Safari-Domain-Card-Date-Edit.1.mp4

Bug6380969_1708019494545.Desktop-Domain-Card-Date-Edit.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010604e6d9dd675bc1
• Upwork Job ID: 1758194441775136768
• Last Price Increase: 2024-03-14
• Automatic offers:
• FitseTLT | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010604e6d9dd675bc1

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

We think that this bug might be related to #vip-vsp
CC @quinthar

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Domain Card - User can edit the date in expenses related to the assigned domain card

What is the root cause of that problem?

The canEditFieldOfMoneyRequest logic doesn't align with the BE requirements to allow editing date field and it allows the edit of date field for domain card transaction unlike amount which is disabled as in here

App/src/libs/ReportUtils.ts

Lines 2162 to 2164 in 1c0d126

	if (fieldToEdit === CONST.EDIT_REQUEST_FIELD.AMOUNT || fieldToEdit === CONST.EDIT_REQUEST_FIELD.CURRENCY) {
	if (TransactionUtils.isCardTransaction(transaction)) {
	return false;

What changes do you think we should make in order to solve the problem?

We should add a code before here

App/src/libs/ReportUtils.ts

Line 2162 in 1c0d126

if (fieldToEdit === CONST.EDIT_REQUEST_FIELD.AMOUNT || fieldToEdit === CONST.EDIT_REQUEST_FIELD.CURRENCY) {

if (fieldToEdit === CONST.EDIT_REQUEST_FIELD.DATE) {
        if (TransactionUtils.isCardTransaction(transaction)) {
            return false;
        }
    }

or change

App/src/libs/ReportUtils.ts

Line 2162 in 1c0d126

if (fieldToEdit === CONST.EDIT_REQUEST_FIELD.AMOUNT || fieldToEdit === CONST.EDIT_REQUEST_FIELD.CURRENCY) {

to

    if (fieldToEdit === CONST.EDIT_REQUEST_FIELD.AMOUNT || fieldToEdit === CONST.EDIT_REQUEST_FIELD.CURRENCY || fieldToEdit === CONST.EDIT_REQUEST_FIELD.DATE) {

What alternative solutions did you explore? (Optional)

[allroundexperts]

@miljakljajic Who can edit these fields? Is it that no one should edit these?

[wildan-m]

Could someone add me to the "Domain Card tests - DO NOT DELETE" group? Alternatively, how can we create the domain card? Can we use a fake card for this purpose?

wildevemail+1@gmail.com