Skip to content

[HOLD for payment 2024-03-07] [$500] Chat – Requested money disappears from conversation in specific account and chat #36582

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.42-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Login with applausetester+jp_e_category@applause.expensifail.com
  3. Navigate to a chat with Admin
  4. Click on the + in the compose box, select "Request money" and complete the flow

Expected Result:

The IOU appears in the conversation

Actual Result:

The IOU appears and disappears in the conversation

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6380691_1708004156480.Requested_money_disappears_from_conversation.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010f81770ce9fdadcb
  • Upwork Job ID: 1758127876420673536
  • Last Price Increase: 2024-02-15
  • Automatic offers:
    • rojiphil | Contributor | 0

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 15, 2024
  2. melvin-bot commented on Feb 15, 2024

    @melvin-bot
  3. changed the title [-]Chat – Requested money disappears from conversation in specific account and chat[/-] [+][$500] Chat – Requested money disappears from conversation in specific account and chat[/+] on Feb 15, 2024
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 15, 2024
  5. melvin-bot commented on Feb 15, 2024

    @melvin-bot

    Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  6. melvin-bot commented on Feb 15, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

  7. kbecciv commented on Feb 15, 2024

    @kbecciv
    Author

    We think that this bug might be related #vip-vsb
    CC @quinthar

  8. allroundexperts commented on Feb 17, 2024

    @allroundexperts
    Contributor

    Looking for proposals.

  9. bernhardoj commented on Feb 17, 2024

    @bernhardoj
    Contributor

    The request preview doesn't disappear but moves up because the BE returns the created value smaller than what it should be. Today is 02-17 but BE returns 02-09
    image

  10. allroundexperts commented on Feb 19, 2024

    @allroundexperts
    Contributor

    Makes sense. Looks like this needs to be internal.

  11. rojiphil commented on Feb 19, 2024

    @rojiphil
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Report Preview disappears from conversation in chat Report

    What is the root cause of that problem?

    Recently, there was an intentional change in BE as mentioned here and here which prevents the Report Preview to move to the latest report action. The Report Preview will remain in the same place where it was earlier. This is the root cause.

    What changes do you think we should make in order to solve the problem?

    We need to prevent updation of created in the Report Preview action during money request generation here

    - created: DateUtils.getDBTime(),

    What alternative solutions did you explore? (Optional)

  12. 14 remaining items

  13. mvtglobally commented on Feb 27, 2024

    @mvtglobally

    Issue not reproducible during KI retests. (First week)

  14. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Feb 29, 2024
  15. changed the title [-][$500] Chat – Requested money disappears from conversation in specific account and chat[/-] [+][HOLD for payment 2024-03-07] [$500] Chat – Requested money disappears from conversation in specific account and chat[/+] on Feb 29, 2024
  16. melvin-bot commented on Feb 29, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  17. melvin-bot commented on Feb 29, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-03-07. 🎊

    For reference, here are some details about the assignees on this issue:

  18. melvin-bot commented on Feb 29, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
    • [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@allroundexperts] Determine if we should create a regression test for this bug.
    • [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  19. alexpensify commented on Mar 1, 2024

    @alexpensify
    Contributor

    Awesome, looks like automation kicked in here.


    Heads up, I will be offline until Tuesday, March 5, 2024. I will not be actively watching over this GitHub during that period. If anything urgent is needed here, please ask for help in the Open Source Slack Room-- thanks!

  20. alexpensify commented on Mar 8, 2024

    @alexpensify
    Contributor

    Here is the payment summary:

    • External issue reporter - N/A
    • Contributor that fixed the issue @rojiphil $500
    • Contributor+ that helped on the issue and/or PR @allroundexperts $500

    Upwork Job: https://www.upwork.com/jobs/~010f81770ce9fdadcb


    @rojiphil has been paid here via Upwork. @allroundexperts please submit a request in Chat. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorMonthlyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions