[HOLD for payment 2024-03-11] [$500] Sign In - 'continue with the web app' link is not working on click #36145

Activity

1. izarutskaya

   added

   ExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributor

   DailyKSv2KSv2

   BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.

   on Feb 8, 2024
2. melvin-bot commented on Feb 8, 2024

   

   melvin-botbot

   on Feb 8, 2024 – with Melvin Bot

   More actions

   Job added to Upwork: https://www.upwork.com/jobs/~018b1482288004dd72
3. melvin-bot

   changed the title [-]Sign In - 'continue with the web app' link is not working on click[/-] [+][$500] Sign In - 'continue with the web app' link is not working on click[/+] on Feb 8, 2024
4. melvin-bot

   added

   Help WantedApply this label when an issue is open to proposals by contributorsApply this label when an issue is open to proposals by contributors

   on Feb 8, 2024
5. melvin-bot

   assigned

   abdulrahuman5196

   on Feb 8, 2024
6. melvin-bot commented on Feb 8, 2024

   

   melvin-botbot

   on Feb 8, 2024 – with Melvin Bot

   More actions

   Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)
7. melvin-bot

   assigned

   jliexpensify

   on Feb 8, 2024
8. melvin-bot commented on Feb 8, 2024

   

   melvin-botbot

   on Feb 8, 2024 – with Melvin Bot

   More actions

   Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
9. izarutskaya commented on Feb 8, 2024

   

   izarutskaya

   on Feb 8, 2024

   Author

   More actions

   We think that this bug might be related to #wave9-collect-signup
   CC @MitchExpensify
10. allgandalf commented on Feb 8, 2024

    

    allgandalf

    on Feb 8, 2024

    Contributor

    More actions

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    continue with the web app' link is not working on click

    What is the root cause of that problem?

    We navigate to HOME on click to the link
    

    App/src/components/DeeplinkWrapper/DeeplinkRedirectLoadingIndicator.tsx

    Line 48 in caefc6e

    {translate('deeplinkWrapper.or')} <TextLink onPress={() => Navigation.navigate(ROUTES.HOME)}>{translate('deeplinkWrapper.continueInWeb')}</TextLink>.

    What changes do you think we should make in order to solve the problem?

    Update the Navigation.navigate to reroute into browser

    What alternative solutions did you explore? (Optional)

    N/A
11. allgandalf commented on Feb 8, 2024

    

    allgandalf

    on Feb 8, 2024

    Contributor

    More actions

    @izarutskaya , the bug video hasn't been uploaded yet, can you please update it :) thanks

    👀React with 👀1Reacted by Irina Zarutskaya
12. izarutskaya commented on Feb 8, 2024

    

    izarutskaya

    on Feb 8, 2024

    Author

    More actions

    Sorry, I added it again
13. DevOpsacmeuniverse commented on Feb 8, 2024

    

    DevOpsacmeuniverse

    on Feb 8, 2024

    More actions

    Do I need to apply through upwork?
14. 40 remaining items

    Load more

15. bernhardoj commented on Feb 26, 2024

    

    bernhardoj

    on Feb 26, 2024

    Contributor

    More actions

    PR is ready

    cc: @abdulrahuman5196
16. melvin-bot

    added

    WeeklyKSv2KSv2

    Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to production

    and removed

    WeeklyKSv2KSv2

    on Mar 4, 2024
17. melvin-bot

    changed the title [-][$500] Sign In - 'continue with the web app' link is not working on click[/-] [+][HOLD for payment 2024-03-11] [$500] Sign In - 'continue with the web app' link is not working on click[/+] on Mar 4, 2024
18. melvin-bot

    removed

    ReviewingHas a PR in reviewHas a PR in review

    on Mar 4, 2024
19. melvin-bot commented on Mar 4, 2024

    

    melvin-botbot

    on Mar 4, 2024 – with Melvin Bot

    More actions

    Reviewing label has been removed, please complete the "BugZero Checklist".
20. melvin-bot commented on Mar 4, 2024

    

    melvin-botbot

    on Mar 4, 2024 – with Melvin Bot

    More actions

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.46-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    • Fix can't close desktop sign in redirect page #37198

    If no regressions arise, payment will be issued on 2024-03-11. 🎊

    For reference, here are some details about the assignees on this issue:

    • @abdulrahuman5196 requires payment automatic offer (Reviewer)
    • @bernhardoj requires payment automatic offer (Contributor)
21. melvin-bot commented on Mar 4, 2024

    

    melvin-botbot

    on Mar 4, 2024 – with Melvin Bot

    More actions

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
    • [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@abdulrahuman5196] Determine if we should create a regression test for this bug.
    • [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
22. abdulrahuman5196 commented on Mar 5, 2024

    

    abdulrahuman5196

    on Mar 5, 2024

    Contributor

    More actions

    The PR that introduced the bug has been identified. Link to the PR:
    The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    Doesn't have regression PR directly. Could be cause of common navigation changes.

    Determine if we should create a regression test for this bug.

    Yes.

    If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    1. Open desktop & navigate to log in page
    2. Click on 'Sign in with Google' icon
    3. Sign in with Google from browser
    4. Click on 'Cancel' on the open desktop app prompt dialog box
    5. Click on 'continue with the web app' link

    👍React with 👍1Reacted by Jason Li
23. melvin-bot

    added

    DailyKSv2KSv2

    and removed

    WeeklyKSv2KSv2

    on Mar 11, 2024
24. jliexpensify commented on Mar 12, 2024

    

    jliexpensify

    on Mar 12, 2024

    Contributor

    More actions

    Payment Summary:

    • C: @bernhardoj $500
    • C+: @abdulrahuman5196 $500

    Upwork job
25. jliexpensify commented on Mar 12, 2024

    

    jliexpensify

    on Mar 12, 2024

    Contributor

    More actions

    Paid and job closed.
26. jliexpensify

    closed this as completedon Mar 12, 2024