Skip to content

[HOLD for payment 2024-04-25] [HOLD for payment 2024-04-15] [HOLD for payment 2024-03-11] [TS migration] Migrate 'withFullTransactionOrNotFound.js' HOC to TypeScript #36123

Closed

Description

@melvin-bot

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/pages/iou/request/step/withFullTransactionOrNotFound.js 11

Activity

  1. MahmudjonToraqulov commented on Feb 14, 2024

    @MahmudjonToraqulov
    Contributor

    I want to work on it

  2. ruben-rebelo commented on Feb 14, 2024

    @ruben-rebelo
    Contributor

    I am Ruben Rebelo from Callstack - expert contributor group. I’d like to work on this job.

  3. melvin-bot commented on Feb 28, 2024

    @melvin-bot
    Author

    Triggered auto assignment to @tylerkaraszewski, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  4. melvin-bot commented on Feb 29, 2024

    @melvin-bot
    Author
  5. 26 remaining items

  6. melvin-bot commented on Apr 8, 2024

    @melvin-bot
    Author

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@tylerkaraszewski] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
  7. parasharrajat commented on Apr 9, 2024

    @parasharrajat
    Member

    Please assign me as C+.

  8. changed the title [-][HOLD for payment 2024-04-15] [HOLD for payment 2024-03-11] [TS migration] Migrate 'withFullTransactionOrNotFound.js' HOC to TypeScript[/-] [+][HOLD for payment 2024-04-25] [HOLD for payment 2024-04-15] [HOLD for payment 2024-03-11] [TS migration] Migrate 'withFullTransactionOrNotFound.js' HOC to TypeScript[/+] on Apr 18, 2024
  9. melvin-bot commented on Apr 18, 2024

    @melvin-bot
    Author

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-25. 🎊

    For reference, here are some details about the assignees on this issue:

  10. melvin-bot commented on Apr 18, 2024

    @melvin-bot
    Author

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@parasharrajat] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
  11. parasharrajat commented on Jun 14, 2024

    @parasharrajat
    Member

    @tylerkaraszewski Could you please post the payment summary?

  12. tylerkaraszewski commented on Jul 1, 2024

    @tylerkaraszewski
    Contributor

    I think that's @garrettmknight's task.

  13. garrettmknight commented on Jul 2, 2024

    @garrettmknight
    Contributor

    Payment summary:

  14. parasharrajat commented on Jul 2, 2024

    @parasharrajat
    Member

    Payment requested as per #36123 (comment)

  15. JmillsExpensify commented on Jul 2, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @parasharrajat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions