Repository navigation
[HOLD for payment 2024-03-20] [LOW] Enable pagination on SelectionList #36121
Description
Activity
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.@cristipaval reporting for duty 🖖
Do we have an update here, @lukemorawski ?
@cristipaval no, sorry, had a more urgent bug fixes. I will be tackling that today
Reacted by April Bekkala@abekkala, @cristipaval, @lukemorawski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
29 remaining items
- changed the title
[-][LOW] Enable pagination on SelectionList[/-][+][HOLD for payment 2024-03-20] [LOW] Enable pagination on SelectionList[/+]on Mar 13, 2024 Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.51-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-03-20. 🎊
For reference, here are some details about the assignees on this issue:
- @lukemorawski does not require payment (Contractor)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@cristipaval] The PR that introduced the bug has been identified. Link to the PR:
- [@cristipaval] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@cristipaval] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@lukemorawski] Determine if we should create a regression test for this bug.
- [@lukemorawski] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
PAYMENT SUMMARY FOR MAR 20
- FIX: @lukemorawski - no payment required
- PR REVIEW: @fedirjh [$500 - if no regression] Offer
@lukemorawski can you complete the checklist above?
no regression test needed
- moved this from Polish to Done in [#whatsnext] #wave-collect
on Mar 20, 2024
Problem
As part of this issue, we refactored the old gigantic
OptionItemcomponent into multiple components focused on specific use cases. The refactoring has taken quite a long time, and in the meantime, pagination was added to the App to make the experience smoother on high-traffic accounts.Currently, the new component
SelectionListdoesn't have pagination, and the Search feature in high-traffic accounts doesn't offer the best experience.Solution
Let's enable pagination on the new
SelectionListcomponent.cc @mountiny
Issue Owner
Current Issue Owner: @cristipaval