[HOLD for payment 2024-02-19] [HOLD for payment 2024-02-15] Web - Report - Blank Concierge report is displayed on back navigation from search page

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.38.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Sign up with a new account
Click on search bar
Click back button

Expected Result:

Concierge report should be opened and report shouldn't be blank

Actual Result:

Blank Concierge report is displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6370432_1707315855833.screen_recording_2024-02-07_at_2.43.00_in_the_afternoon.mp4

View all open jobs on GitHub

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@tgolen

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@quinthar

We think that this bug might be related #vip-vsb
CC @quinthar

Proposal

Please re-state the problem that we are trying to solve in this issue.

Blank Concierge report is displayed on back navigation from search page

What is the root cause of that problem?

We don't have onBackBuuttonPress prop passed to HeaderWithBackButton

App/src/pages/SearchPage/index.js

Line 149 in fc4a44f

What changes do you think we should make in order to solve the problem?

Update HeaderWithBackButton to the following

<HeaderWithBackButton
                        title={translate('common.search')}
                        onBackButtonPress={Navigation.goBack}
                    />

What alternative solutions did you explore? (Optional)

N/A

@lukemorawski

regression from #35058
cc: @lukemorawski

@lukemorawski

@lukemorawski Is this something you will be able to fix ASAP?

@trjExpensify

The root cause is same as other holding issues like #35965, #35969
@trjExpensify should we hold this as well?

Yeah, I think we should. I'll put this on HOLD.

@adamgrzybowski

cc: @adamgrzybowski to put in your PR

Fix CP'd to staging. I updated the checklist and removed the blocker label.

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.38-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] SearchPage back button issue fix #36141

If no regressions arise, payment will be issued on 2024-02-15. 🎊

No payments required

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.39-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] SearchPage back button issue fix #36141

If no regressions arise, payment will be issued on 2024-02-19. 🎊

Navigation Menu

Repository navigation

[HOLD for payment 2024-02-19] [HOLD for payment 2024-02-15] Web - Report - Blank Concierge report is displayed on back navigation from search page #36035

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

23 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-02-19] [HOLD for payment 2024-02-15] Web - Report - Blank Concierge report is displayed on back navigation from search page #36035

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

github-actions commented on Feb 7, 2024

melvin-bot commented on Feb 7, 2024

kbecciv commented on Feb 7, 2024

allgandalf commented on Feb 7, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

situchan commented on Feb 7, 2024

tgolen commented on Feb 7, 2024

situchan commented on Feb 7, 2024

tgolen commented on Feb 7, 2024

situchan commented on Feb 7, 2024

23 remaining items

Julesssss commented on Feb 8, 2024

melvin-bot commented on Feb 8, 2024

melvin-bot commented on Feb 8, 2024

mountiny commented on Feb 8, 2024

melvin-bot commented on Feb 12, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions