Skip to content

[$500] Referral - Referral banner is not permanently dismissed in Search #35895

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Found when validating PR: #34842

Version Number: v.1.4-37.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Click on the Search bar.
  3. Dismiss referral banner.
  4. Close the search modal.
  5. Reopen the search modal.

Expected Result:

The referral banner will not permanently dismissed.

Actual Result:

The referral banner reappears after reopening the Search modal.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6369092_1707216580629.bandicam_2024-02-06_08-45-04-820.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01fa00f6ce5b45ba2f
  • Upwork Job ID: 1754832589427269632
  • Last Price Increase: 2024-02-13

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 6, 2024
  2. changed the title [-]Referral - Referral banner is not permanently dismissed in Search[/-] [+][$500] Referral - Referral banner is not permanently dismissed in Search[/+] on Feb 6, 2024
  3. melvin-bot commented on Feb 6, 2024

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 6, 2024
  5. melvin-bot commented on Feb 6, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

  6. melvin-bot commented on Feb 6, 2024

    @melvin-bot

    Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  7. github-actions commented on Feb 6, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. 17 remaining items

  9. changed the title [-][HOLD App #35058] [$500] Referral - Referral banner is not permanently dismissed in Search[/-] [+][$500] Referral - Referral banner is not permanently dismissed in Search[/+] on Feb 12, 2024
  10. MariaHCD commented on Feb 12, 2024

    @MariaHCD
    Contributor

    Off hold.

  11. melvin-bot commented on Feb 13, 2024

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  12. DylanDylann commented on Feb 13, 2024

    @DylanDylann
    Contributor

    @codinggeek2023 @BhuvaneshPatil COuld you reproduce this issue anymore?

  13. eucool commented on Feb 13, 2024

    @eucool
    Contributor

    Not reproducible on staging, ig this was fixed in the PR which you mentioned above :)

  14. DylanDylann commented on Feb 13, 2024

    @DylanDylann
    Contributor

    @JmillsExpensify I also can't reproduce. Let's close this one

  15. eucool commented on Feb 13, 2024

    @eucool
    Contributor

    lets rest this issue in peace 😆

  16. MariaHCD commented on Feb 16, 2024

    @MariaHCD
    Contributor

    Thanks, all. Confirmed that the issue is no longer reproducible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions