Skip to content

[$250] Workspace switcher - Workspace switcher reopens after selecting a workspace with keyboard #35823

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: .1.4-36.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition:

  • User has less than 7 workspaces
  • Workspace filter is "Expensify"
  1. Go to staging.new.expensify.com
  2. Open workspace switcher
  3. Click on any workspace
  4. Open workspace switcher again
  5. Using keyboard arrow key, select another workspace and hit Enter

Expected Result:

The workspace switcher will not reopen

Actual Result:

The workspace switcher reopens

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6367586_1707134336234.20240204_225718.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012b6b390114d02e71
  • Upwork Job ID: 1754525872518934528
  • Last Price Increase: 2024-02-26
Issue OwnerCurrent Issue Owner: @isabelastisser

Activity

  1. github-actions commented on Feb 5, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Feb 5, 2024

    @melvin-bot

    Triggered auto assignment to @mountiny (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. moved this to Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals) in [#whatsnext] Wave 08 - Collect Plan Adminson Feb 5, 2024
  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Feb 5, 2024
  5. changed the title [-]Workspace switcher - Workspace switcher reopens after selecting a workspace with keyboard[/-] [+][$500] Workspace switcher - Workspace switcher reopens after selecting a workspace with keyboard[/+] on Feb 5, 2024
  6. melvin-bot commented on Feb 5, 2024

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 5, 2024
  8. 126 remaining items

  9. sakluger commented on May 17, 2024

    @sakluger
    Contributor

    Catching up here, it sounds like:

    1. The issue mostly self-resolved
    2. We still merged & deployed the PR for the proposed fix because it will prevent similar issues from cropping up in the future

    @isabelastisser could you please help process the payment for this issue since I'm going OOO today for the next two weeks? Thanks!

  10. self-assigned this
    on May 17, 2024
  11. isabelastisser commented on May 18, 2024

    @isabelastisser
    Contributor

    Payment summary:

    @getusha C+ review $250
    @cdOut Contributor - Agency, no payment is needed.

    https://www.upwork.com/ab/applicants/1791896534622019584/job-details

  12. isabelastisser commented on May 18, 2024

    @isabelastisser
    Contributor

    @getusha and @cdOut, I can't find you in Upwork. Please share your Upwork profiles here. Thanks!

  13. getusha commented on May 19, 2024

    @getusha
    Contributor

    @isabelastisser accepted the offer

  14. mountiny commented on May 20, 2024

    @mountiny
    Contributor

    @cdOut is agency worker so no payment there

    Once @getusha is paid out we can close this issue @isabelastisser

  15. isabelastisser commented on May 21, 2024

    @isabelastisser
    Contributor

    @getusha, can you please share your Upwork profile? Thanks!

  16. situchan commented on May 21, 2024

    @situchan
    Contributor

    Am I eligible for partial payment for proposals review? I had to reassign just because of OOO, while waiting for agency PR.

  17. getusha commented on May 22, 2024

    @getusha
    Contributor

    @getusha, can you please share your Upwork profile? Thanks!

    @isabelastisser https://www.upwork.com/freelancers/~01460cf774c356f209

  18. mountiny commented on May 23, 2024

    @mountiny
    Contributor

    @situchan I think that in this we will just move ahead, the most work has been done on the PR and the review/ checklist/ testing there so I would say only $250 to @getusha in this case.

    There will be many more opportunities for you

  19. isabelastisser commented on May 24, 2024

    @isabelastisser
    Contributor

    Thanks, team! Closing.

  20. getusha commented on May 24, 2024

    @getusha
    Contributor

    @isabelastisser accepted the offer, could you end it? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in review

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions