Skip to content

[HOLD for payment 2024-02-14] [$500] New Workspace button does not work #35820

Closed

Description

@mountiny

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.36-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation:

Action Performed:

Break down in numbered steps

  1. Sign up to an account which does not have any workspace yet
  2. Click the wrench to go to Settings
  3. Go to workspaces
  4. Click the New Workspace button in the big section block
  5. Verify the workspace got created

Expected Result:

Describe what you think should've happened

Actual Result:

Describe what actually happened

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019da9053a5e89dbe2
  • Upwork Job ID: 1754522202320949248
  • Last Price Increase: 2024-02-05
  • Automatic offers:
    • ishpaul777 | Contributor | 28142786

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 5, 2024
  2. self-assigned this
    on Feb 5, 2024
  3. melvin-bot commented on Feb 5, 2024

    @melvin-bot

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. github-actions commented on Feb 5, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Feb 5, 2024

    @melvin-bot

    Current assignee @mountiny is eligible for the Engineering assigner, not assigning anyone new.

  6. mountiny commented on Feb 5, 2024

    @mountiny
    ContributorAuthor

    PR in review

  7. 13 remaining items

  8. mountiny commented on Feb 5, 2024

    @mountiny
    ContributorAuthor

    This was fixed

  9. jliexpensify commented on Feb 6, 2024

    @jliexpensify
    Contributor

    Upworks job closed

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Feb 7, 2024
  11. changed the title [-][$500] New Workspace button does not work[/-] [+][HOLD for payment 2024-02-14] [$500] New Workspace button does not work[/+] on Feb 7, 2024
  12. melvin-bot commented on Feb 7, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Feb 7, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-02-14. 🎊

  14. melvin-bot commented on Feb 7, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
    • [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@mountiny] Determine if we should create a regression test for this bug.
    • [@mountiny] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  15. s77rt commented on Feb 8, 2024

    @s77rt
    Member
  16. mountiny commented on Feb 8, 2024

    @mountiny
    ContributorAuthor

    Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions