You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-02-14] [$500] mWeb - Magic link - "Sign in here" leads to Abracadabra page. #35782
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-]mWeb - Magic link - "Sign in here" leads to Abracadabra page.[/-][+][$500] mWeb - Magic link - "Sign in here" leads to Abracadabra page.[/+]on Feb 5, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
[@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@Ollyws] Determine if we should create a regression test for this bug.
[@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
github-actions commentedon Feb 4, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Feb 4, 2024
Triggered auto assignment to @yuwenmemon (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.[-]mWeb - Magic link - "Sign in here" leads to Abracadabra page.[/-][+][$500] mWeb - Magic link - "Sign in here" leads to Abracadabra page.[/+]melvin-bot commentedon Feb 5, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01ce9d90ffdb97284c
melvin-bot commentedon Feb 5, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (
External)melvin-bot commentedon Feb 5, 2024
Triggered auto assignment to @zanyrenney (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.30 remaining items
melvin-bot commentedon Feb 7, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Feb 7, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-02-14. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Feb 7, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
zanyrenney commentedon Feb 15, 2024
@Ollyws @aswin-s you have not accepted the offers, please accept for payout,
aswin-s commentedon Feb 15, 2024
@zanyrenney Accepted the offer
Ollyws commentedon Feb 15, 2024
I didn't review this one, no payment required for me.
zanyrenney commentedon Feb 16, 2024
Payment summary
@aswin-s requires payment automatic offer (Contributor) - PAID $500
@Ollyws requires payment automatic offer (Reviewer) - no review, no payment due.