Skip to content

[HOLD for payment 2024-02-14] [$500] mWeb - Magic link - "Sign in here" leads to Abracadabra page. #35782

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.36
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4279569
Email or phone of affected tester (no customers): vdargentotest+mweb020224@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. On login page, enter an email you have access to
  3. Go to email inbox and copy the magic link
  4. Change the link to staging and go to it on an incognito window
  5. Tap on "just sign here"

Expected Result:

The user should be logged in and the LHN should be displayed

Actual Result:

The user should be logged in and the LHN should be displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6366539_1707025723935.RPReplay_Final1706914322.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ce9d90ffdb97284c
  • Upwork Job ID: 1754498791034695680
  • Last Price Increase: 2024-02-05
  • Automatic offers:
    • Ollyws | Reviewer | 28143590
    • aswin-s | Contributor | 28143592

Activity

  1. github-actions commented on Feb 4, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Feb 4, 2024

    @melvin-bot

    Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 5, 2024
  4. changed the title [-]mWeb - Magic link - "Sign in here" leads to Abracadabra page.[/-] [+][$500] mWeb - Magic link - "Sign in here" leads to Abracadabra page.[/+] on Feb 5, 2024
  5. melvin-bot commented on Feb 5, 2024

    @melvin-bot
  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 5, 2024
  7. melvin-bot commented on Feb 5, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

  8. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 5, 2024
  9. melvin-bot commented on Feb 5, 2024

    @melvin-bot

    Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  10. 30 remaining items

  11. melvin-bot commented on Feb 7, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Feb 7, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-02-14. 🎊

    For reference, here are some details about the assignees on this issue:

  13. melvin-bot commented on Feb 7, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
    • [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@Ollyws] Determine if we should create a regression test for this bug.
    • [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  14. zanyrenney commented on Feb 15, 2024

    @zanyrenney
    Contributor

    @Ollyws @aswin-s you have not accepted the offers, please accept for payout,

  15. aswin-s commented on Feb 15, 2024

    @aswin-s
    Contributor

    @zanyrenney Accepted the offer

  16. Ollyws commented on Feb 15, 2024

    @Ollyws
    Contributor

    I didn't review this one, no payment required for me.

  17. zanyrenney commented on Feb 16, 2024

    @zanyrenney
    Contributor

    Payment summary

    @aswin-s requires payment automatic offer (Contributor) - PAID $500
    @Ollyws requires payment automatic offer (Reviewer) - no review, no payment due.

  18. added
    ReviewingHas a PR in review
    and removed on Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions