Repository navigation
[$500] [HOLD for payment 2024-02-14] mweb - Compose - Tapping emoji picker, keypad pops up on emoji box page #35720
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.5.36.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4279600
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
- Go to https://staging.new.expensify.com/
- Tap on a report
- Tap emoji picker from compose box
Expected Result:
When user taps emoji picker, keypad must not pop up on emoji box page
Actual Result:
When user taps emoji picker, keypad pops up on emoji box page
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6365232_1706901898987.az_recorder_20240203_004927.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01ad9a549f2e03c9fe
- Upwork Job ID: 1757788628485996544
- Last Price Increase: 2024-02-14
Activity
github-actions commentedon Feb 2, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Feb 2, 2024
Triggered auto assignment to @aldo-expensify (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.kbecciv commentedon Feb 2, 2024
We think that this bug might be related to #vip-vsb
CC @quinthar
aldo-expensify commentedon Feb 2, 2024
Reproduced in
stagingand can't reproduce inproductionScreenrecorder-2024-02-02-12-54-23-788.mp4
aldo-expensify commentedon Feb 2, 2024
Sorry, got distracted with other issues. I think the keyboard appears immediately because the "Search" field gets automatically focused. I don't see that auto-focus in production.
francoisl commentedon Feb 2, 2024
This might not be worth being a blocker, but yes ideally we'd stay consistent with other platforms and not show the keyboard.
francoisl commentedon Feb 2, 2024
Could be a red herring but this PR from the checklist modified the EmojiPicker #34581
aldo-expensify commentedon Feb 2, 2024
I noticed this PR, but it doesn't appear to be in staging yet, or at least the comment of deployment to staging is missing
aldo-expensify commentedon Feb 2, 2024
Seems like I'm wrong and the #34581 is already merged in version
v1.4.36-0unless I'm looking at the wrong thingsaldo-expensify commentedon Feb 2, 2024
tested a revert of the PR #35737 and it does fix the deploy blocker
francoisl commentedon Feb 2, 2024
Hm yeah there was supposed to be a comment in the PR saying that it was deployed to staging, looks like a bug :(
I checked the
1.4.36-0tag locally and the code from that PR is definitely on it, so yes it's deployed to staging at the moment.26 remaining items
melvin-bot commentedon Feb 14, 2024
Issue is ready for payment but no BZ is assigned. @alexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
melvin-bot commentedon Feb 14, 2024
Payment Summary
Upwork Job
BugZero Checklist (@alexpensify)
[-][HOLD for payment 2024-02-14] mweb - Compose - Tapping emoji picker, keypad pops up on emoji box page[/-][+][$500] [HOLD for payment 2024-02-14] mweb - Compose - Tapping emoji picker, keypad pops up on emoji box page[/+]melvin-bot commentedon Feb 14, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01ad9a549f2e03c9fe
melvin-bot commentedon Feb 14, 2024
Current assignee @jjcoffee is eligible for the External assigner, not assigning anyone new.
alexpensify commentedon Feb 14, 2024
@jjcoffee - another one to accept, thanks!
https://www.upwork.com/jobs/~01ad9a549f2e03c9fe
jjcoffee commentedon Feb 14, 2024
@alexpensify Ah sorry, I think no payment is due on this one as it was just a minor regression fix!
alexpensify commentedon Feb 14, 2024
@jjcoffee thanks for flagging, let me review and I'll reply tomorrow with an update.
alexpensify commentedon Feb 15, 2024
Ok, I've closed the job in Upwork but still left positive feedback. Thanks again for your help and flagging the payment breakdown here.