Skip to content

Group - All recents users selected when clicking on "Add to group" #35701

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.36-0
Reproducible in staging?: y
Reproducible in production?: yn
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Click on "+"
  2. Go to the "Start chat"
  3. Click on "Add to group" of recents users

Expected Result:

Only one user should be selected when clicking on "Add to group"

Actual Result:

All recents users selected when clicking on "Add to group"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6365181_1706899051810.2024-02-02_21-31-14.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016be032c785f4143f
  • Upwork Job ID: 1754458637091528704
  • Last Price Increase: 2024-02-05

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    and removed on Feb 2, 2024
  2. github-actions commented on Feb 2, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. melvin-bot commented on Feb 2, 2024

    @melvin-bot

    Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. kbecciv commented on Feb 2, 2024

    @kbecciv
    Author

    We think that this bug might be related to #vip-vsb
    CC @quinthar

  5. shubham1206agra commented on Feb 2, 2024

    @shubham1206agra
    Contributor

    Offending PR: #34847
    cc @Krishna2323

  6. Krishna2323 commented on Feb 2, 2024

    @Krishna2323
    Contributor

    @shubham1206agra, I don't think it's coming from that PR, still looking at it.

  7. marcaaron commented on Feb 3, 2024

    @marcaaron
    Contributor

    I believe it is caused by this very large PR

    Debugging locally and there seems to be some issue with this commit

  8. 25 remaining items

  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Feb 7, 2024
  10. changed the title [-][$500] Group - All recents users selected when clicking on "Add to group"[/-] [+][HOLD for payment 2024-02-14] [$500] Group - All recents users selected when clicking on "Add to group"[/+] on Feb 7, 2024
  11. melvin-bot commented on Feb 7, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Feb 7, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-02-14. 🎊

    For reference, here are some details about the assignees on this issue:

    • @s77rt requires payment (Needs manual offer from BZ)
  13. melvin-bot commented on Feb 7, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
    • [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@s77rt] Determine if we should create a regression test for this bug.
    • [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  14. s77rt commented on Feb 8, 2024

    @s77rt
    Member
    • The PR that introduced the bug has been identified: [Wave 8] Ideal nav  #33280
    • The offending PR has been commented on: Not needed
    • A discussion in #expensify-bugs has been started: n/a
    • Determine if we should create a regression test for this bug: No
  15. MitchExpensify commented on Feb 8, 2024

    @MitchExpensify
    Contributor

    Payment summary:

    $500 - @s77rt (NewDot)

  16. s77rt commented on Feb 9, 2024

    @s77rt
    Member

    @MitchExpensify No payment is required here.

  17. changed the title [-][HOLD for payment 2024-02-14] [$500] Group - All recents users selected when clicking on "Add to group"[/-] [+]Group - All recents users selected when clicking on "Add to group"[/+] on Feb 9, 2024
  18. hayata-suenaga commented on Feb 9, 2024

    @hayata-suenaga
    Contributor

    yep this is an issue for a regression stemmed from the Ideal Nav PR

    sorry about that I should have specified that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions