You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Group - All recents users selected when clicking on "Add to group" #35701
Version Number: v1.4.36-0 Reproducible in staging?: y Reproducible in production?: yn If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
Click on "+"
Go to the "Start chat"
Click on "Add to group" of recents users
Expected Result:
Only one user should be selected when clicking on "Add to group"
Actual Result:
All recents users selected when clicking on "Add to group"
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-][$500] Group - All recents users selected when clicking on "Add to group"[/-][+][HOLD for payment 2024-02-14] [$500] Group - All recents users selected when clicking on "Add to group"[/+]on Feb 7, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@s77rt] The PR that introduced the bug has been identified. Link to the PR:
[@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@s77rt] Determine if we should create a regression test for this bug.
[@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2024-02-14] [$500] Group - All recents users selected when clicking on "Add to group"[/-][+]Group - All recents users selected when clicking on "Add to group"[/+]on Feb 9, 2024
Activity
github-actions commentedon Feb 2, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Feb 2, 2024
Triggered auto assignment to @marcaaron (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.kbecciv commentedon Feb 2, 2024
We think that this bug might be related to #vip-vsb
CC @quinthar
shubham1206agra commentedon Feb 2, 2024
Offending PR: #34847
cc @Krishna2323
Krishna2323 commentedon Feb 2, 2024
@shubham1206agra, I don't think it's coming from that PR, still looking at it.
marcaaron commentedon Feb 3, 2024
I believe it is caused by this very large PR
Debugging locally and there seems to be some issue with this commit
25 remaining items
[-][$500] Group - All recents users selected when clicking on "Add to group"[/-][+][HOLD for payment 2024-02-14] [$500] Group - All recents users selected when clicking on "Add to group"[/+]melvin-bot commentedon Feb 7, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Feb 7, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-02-14. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Feb 7, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
s77rt commentedon Feb 8, 2024
MitchExpensify commentedon Feb 8, 2024
Payment summary:
$500 - @s77rt (NewDot)
s77rt commentedon Feb 9, 2024
@MitchExpensify No payment is required here.
[-][HOLD for payment 2024-02-14] [$500] Group - All recents users selected when clicking on "Add to group"[/-][+]Group - All recents users selected when clicking on "Add to group"[/+]hayata-suenaga commentedon Feb 9, 2024
yep this is an issue for a regression stemmed from the Ideal Nav PR
sorry about that I should have specified that