Repository navigation
[$125] Workspace switcher - Workspace dropdown button is hardly visible when hovering over it #35686
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: .1.4-36.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
- Go to https://staging.new.expensify.com/
- Hover over workspace switcher
Expected Result:
The dropdown button will be visible
Actual Result:
The dropdown button is hardly visible when hovering over it.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6365101_1706895013722.20240202_232856__1_.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01e08e86679fe960fc
- Upwork Job ID: 1753533589875175424
- Last Price Increase: 2024-02-02
Activity
github-actions commentedon Feb 2, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Feb 2, 2024
Triggered auto assignment to @roryabraham (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.lanitochka17 commentedon Feb 2, 2024
We think that this bug might be related to #vip-vsp
CC @quinthar
esh-g commentedon Feb 2, 2024
Screen.Recording.2024-02-02.at.11.31.53.PM.mov
How about we have it lighter instead of darker (for dark theme at least)
luacmartins commentedon Feb 2, 2024
I don't think this is a blocker. Gonna demote it and we can get contributors to work on it.
[-]Workspace switcher - Workspace dropdown button is hardly visible when hovering over it[/-][+][$500] Workspace switcher - Workspace dropdown button is hardly visible when hovering over it[/+]melvin-bot commentedon Feb 2, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01e08e86679fe960fc
melvin-bot commentedon Feb 2, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (
External)[-][$500] Workspace switcher - Workspace dropdown button is hardly visible when hovering over it[/-][+][$125] Workspace switcher - Workspace dropdown button is hardly visible when hovering over it[/+]melvin-bot commentedon Feb 2, 2024
Upwork job price has been updated to $125
melvin-bot commentedon Feb 2, 2024
Triggered auto assignment to @greg-schroeder (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.rayane-d commentedon Feb 2, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Workspace dropdown button is hardly visible when hovering over it
What is the root cause of that problem?
The root cause is the fill color here when the button is hovered:
App/src/components/WorkspaceSwitcherButton.tsx
Line 58 in cac0a85
the
theme.buttonHoveredBGcolor isproductDark500:App/src/styles/theme/themes/dark.ts
Line 28 in cac0a85
What changes do you think we should make in order to solve the problem?
We should change it to a lighter dark color in the dark mode, maybe to
appBG(productDark100) orhighlightBG(productDark200)What alternative solutions did you explore? (Optional)
s77rt commentedon Feb 2, 2024
We already have an issue for that #35618. We can close this cc @greg-schroeder
luacmartins commentedon Feb 5, 2024
Closing in favor of #35618. Thanks for the link @s77rt