Skip to content

[HOLD for payment 2024-02-19] [$500] [Wave 8][Ideal Nav] Workspace - Workspace is opened with 3-dot menu when long clicking and dragging over options #35681

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4-36.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to Settings > Workspaces
  2. Click 3-dot menu on any workspace
  3. Long click on the menu option and drag below the options

Expected Result:

App will remain on the same page as user is not clicking on the workspace

Actual Result:

App opens the workspace page and the 3-dot menu is opened

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6365092_1706894812322.20240202_234323__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018defc2f43eca6cda
  • Upwork Job ID: 1753500981124509696
  • Last Price Increase: 2024-02-02
  • Automatic offers:
    • ishpaul777 | Reviewer | 28142881
    • bernhardoj | Contributor | 28142882

Activity

  1. github-actions commented on Feb 2, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Feb 2, 2024

    @melvin-bot

    Triggered auto assignment to @dangrous (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. lanitochka17 commented on Feb 2, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-vsp
    CC @quinthar

  4. dangrous commented on Feb 2, 2024

    @dangrous
    Contributor

    oh this is odd, huh. Will try to figure it out

  5. dangrous commented on Feb 2, 2024

    @dangrous
    Contributor

    Following the instructions here - I don't think this needs to be a blocker, as it's very minor/unusual behavior.

  6. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Feb 2, 2024
  7. changed the title [-]Workspace - Workspace is opened with 3-dot menu when long clicking and dragging over options[/-] [+][Wave 8][Ideal Nav] Workspace - Workspace is opened with 3-dot menu when long clicking and dragging over options[/+] on Feb 2, 2024
  8. moved this to Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals) in [#whatsnext] Wave 08 - Collect Plan Adminson Feb 2, 2024
  9. 25 remaining items

  10. melvin-bot commented on Feb 12, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Feb 12, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.39-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-02-19. 🎊

    For reference, here are some details about the assignees on this issue:

  12. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 16, 2024
  13. melvin-bot commented on Feb 16, 2024

    @melvin-bot

    Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  14. sonialiap commented on Feb 19, 2024

    @sonialiap
    Contributor

    @bernhardoj Contributor - $500 payment sent
    @ishpaul777 Reviewer - $500 payment sent

  15. sonialiap commented on Feb 19, 2024

    @sonialiap
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
    • [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@ishpaul777] Determine if we should create a regression test for this bug.
    • [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  16. ishpaul777 commented on Feb 19, 2024

    @ishpaul777
    Contributor
    • [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR:

    Bug was there but it only pops up with #33280

    • [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: very unusual bug PR was not directly responsible to introducing it

    • [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: no need

    • [@ishpaul777] Determine if we should create a regression test for this bug.

    Minor and unusal issue no need for regression test.

    • [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  17. moved this from Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals) to Done in [#whatsnext] Wave 08 - Collect Plan Adminson Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions