Repository navigation
[ON HOLD] [$500] Split - Error above split button disappears when merchant is not entered #35667
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.3.45-5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4264387
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
1, Go to workspace chat
2. Click + > Split bill
3. Create a bill split with an invalid receipt
4. When the scanning fails, click on the split preview
5. Click Amount
6. Enter amount and save
Expected Result:
The error above split button will remain as not all the required fields (Merchant) are entered
Actual Result:
The error above split button disappears when merchant is not entered
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6364785_1706877386715.20240202_124142.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01e2368e0550fbbb4b
- Upwork Job ID: 1753420140902309888
- Last Price Increase: 2024-02-23
Activity
melvin-bot commentedon Feb 2, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01e2368e0550fbbb4b
[-]Split - Error above split button disappears when merchant is not entered[/-][+][$500] Split - Error above split button disappears when merchant is not entered[/+]melvin-bot commentedon Feb 2, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (
External)melvin-bot commentedon Feb 2, 2024
Triggered auto assignment to @alexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.lanitochka17 commentedon Feb 2, 2024
We think that this bug might be related to #vip-split-p2p-chat-groups
bernhardoj commentedon Feb 2, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
The required fields error disappears after we update the amount of a failed split bill.
What is the root cause of that problem?
One of the condition for the error to show is the transaction missing required fields data.
App/src/components/MoneyRequestConfirmationList.js
Line 282 in 8f58898
App/src/libs/TransactionUtils.ts
Lines 167 to 169 in 8f58898
The merchant is only required if it's an expense request and it should be true for our case. It checks the report from the transaction reportID, but in the split case, the report ID is a constant of -2.
App/src/libs/actions/IOU.js
Lines 1418 to 1421 in 8f58898
This is because a split request doesn't have an IOU report (I guess).
So, the expense request check is always false, and updating the amount is enough to remove the required fields error message.
What changes do you think we should make in order to solve the problem?
Instead of relying on the transaction report ID, we can pass the value from the params.
App/src/components/MoneyRequestConfirmationList.js
Line 282 in 8f58898
and we can pass
props.isPolicyExpenseChatas the value.or we can keep the parent report type check and the new param, so we will rely on 2 values
else, we can pass anything optional like report ID that can be used to detect whether it's an expense report or not
What alternative solutions did you explore? (Optional)
We can set the report ID to the split transaction, but I guess we need to do it on BE too which might not be the best solution.
alexpensify commentedon Feb 2, 2024
@abdulrahuman5196 when you get a chance, let us know if this proposal will fix this issue. Thanks!
abdulrahuman5196 commentedon Feb 5, 2024
Will work on review today
9 remaining items
alexpensify commentedon Feb 12, 2024
@abdulrahuman5196 - should we start a discussion in the Slack room to confirm the process for this one?
mvtglobally commentedon Feb 13, 2024
Issue not reproducible during KI retests. (First week)
abdulrahuman5196 commentedon Feb 14, 2024
@alexpensify yes. We should check internally
alexpensify commentedon Feb 14, 2024
Will do! I'll start one soon.
alexpensify commentedon Feb 15, 2024
@abdulrahuman5196 - Since this one didn't appear in recent retests and you noticed a difference in behaviors. I'm going to put this one on hold and we can confirm next week if we should close.
[-][$500] Split - Error above split button disappears when merchant is not entered[/-][+][ON HOLD] [$500] Split - Error above split button disappears when merchant is not entered[/+]melvin-bot commentedon Feb 16, 2024
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
alexpensify commentedon Feb 23, 2024
Still on hold
melvin-bot commentedon Feb 23, 2024
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
alexpensify commentedon Feb 28, 2024
I'm going to close since this issue appears to have stopped.
melvin-bot commentedon Mar 5, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
alexpensify commentedon Mar 5, 2024
I checked and this notice is related to #34916 (comment) -- not this GH. No action is required here.