Skip to content

[HOLD for payment 2024-02-19] [Wave8] [Account Settings] Update the HeaderWithBackButton component to work well with the new design #35609

Description

@mountiny

Coming from tracking issue for this initiative.

Using the Figma final mocks, please update the HeaderWithBackButton component so it can be reused well in the new design

image

For help with anything unclear, please, post in wave8 room.

cc @trjExpensify @dannymcclain

Activity

  1. self-assigned this
    on Feb 1, 2024
  2. melvin-bot commented on Feb 1, 2024

    @melvin-bot
  3. moved this to Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals) in [#whatsnext] Wave 08 - Collect Plan Adminson Feb 1, 2024
  4. kosmydel commented on Feb 2, 2024

    @kosmydel
    Contributor

    Hey, I'm from SWM, and I will work on this.

  5. kosmydel commented on Feb 2, 2024

    @kosmydel
    Contributor

    The PR is ready for review. Can someone from the design team have a look at the results to verify padding, sizes, etc.?

    cc @trjExpensify, @shawnborton

  6. 6 remaining items

  7. melvin-bot commented on Feb 9, 2024

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  8. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Feb 12, 2024
  9. changed the title [-][Wave8] [Account Settings] Update the HeaderWithBackButton component to work well with the new design[/-] [+][HOLD for payment 2024-02-19] [Wave8] [Account Settings] Update the HeaderWithBackButton component to work well with the new design[/+] on Feb 12, 2024
  10. melvin-bot commented on Feb 12, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Feb 12, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.39-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-02-19. 🎊

    For reference, here are some details about the assignees on this issue:

    • @kosmydel does not require payment (Contractor)
  12. melvin-bot commented on Feb 12, 2024

    @melvin-bot

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@kosmydel] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
  13. mountiny commented on Feb 14, 2024

    @mountiny
    ContributorAuthor

    Payment handled here #35571

  14. moved this from Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals) to Done in [#whatsnext] Wave 08 - Collect Plan Adminson Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionNewFeatureSomething to build that is a new item.WeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions