[HOLD for payment 2024-03-13] [$500] mWeb - Welcome to Expensify is shown for existing user after logging in from public room

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.34-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause -Internal Team
Slack conversation:

Action Performed:

Log out of New Expensify
Navigate to this link - https://staging.new.expensify.com/r/5408450846930023
Click on Sign In
Login in with an existing account

Expected Result:

Public room chat history should be displayed.
Welcome to Expensify message should be either shown before logging in or not at all for existing users

Actual Result:

Welcome to Expensify screen is shown after log in, user is forced to close it to view public room chat history

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6362919_1706736644415.Record_2024-01-31-20-50-10.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01adefc3ca63c114f2
Upwork Job ID: 1752868613105299456
Last Price Increase: 2024-02-15
Automatic offers:

situchan | Contributor | 0

Job added to Upwork: https://www.upwork.com/jobs/~01adefc3ca63c114f2

@sakluger

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@Santhosh-Sellavel

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

@quinthar

We think that this bug might be related to #vip-vsp
CC @quinthar

Proposal

Please re-state the problem that we are trying to solve in this issue.

Engagement modal is shown while visiting a public room via deep link as an anonymous user.

What is the root cause of that problem?

The check for showing engagement model is performed inside BottomTabBar in a useEffect.

App/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx

Line 55 in 3e77445

Welcome.show(routes, () => Navigation.navigate(ROUTES.ONBOARD));

Inside Welcome.show method, the engamement modal is shown if current user is isFirstTimeNewExpensifyUser.

App/src/libs/actions/Welcome.ts

Lines 130 to 132 in 3e77445

    
           if (!isFirstTimeNewExpensifyUser) { 
        
               return; 
        
           }

App/src/libs/actions/Welcome.ts

Lines 171 to 173 in 3e77445

    
           if (!Policy.isAdminOfFreePolicy(allPolicies ?? undefined) && !isExitingToWorkspaceRoute && !hasSelectedChoice && !hasDismissedModal && Object.keys(allPolicies ?? {}).length === 1) { 
        
               showEngagementModal(); 
        
           }

However the above check doesn't consider whether the current user is an anonymous user. That's why the engagement modal gets shown for anonymous user.

What changes do you think we should make in order to solve the problem?

Check if current user is an anonymous user before showing engagement modal.

// Add check for anonymous user
if (!Session.isAnonymousUser() && !Policy.isAdminOfFreePolicy(allPolicies ?? undefined) && !isExitingToWorkspaceRoute && !hasSelectedChoice && !hasDismissedModal && Object.keys(allPolicies ?? {}).length === 1) {
  showEngagementModal();
}

What alternative solutions did you explore? (Optional)

None

I asked in #vip-vsb if this is a bug or expected behavior: https://expensify.slack.com/archives/C066HJM2CAZ/p1707178252015419

Reviewing label has been removed, please complete the "BugZero Checklist".

@aswin-s

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.47-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: disable engagement modal display for anonymous users #37673

If no regressions arise, payment will be issued on 2024-03-13. 🎊

For reference, here are some details about the assignees on this issue:

@aswin-s requires payment (Needs manual offer from BZ)
@situchan requires payment automatic offer (Contributor)

@situchan

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@situchan] The PR that introduced the bug has been identified. Link to the PR:
[@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@situchan] Determine if we should create a regression test for this bug.
[@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@aswin-s

Summarizing payment on this issue:

Contributor: @aswin-s $500, sent offer via Upwork (https://www.upwork.com/nx/wm/offer/101367608/)
Contributor+: @situchan $500, paid via Upwork

@situchan could you please complete the BZ checklist?

This was missing test case from new feature of engagement modal. Not regression.

Regression Test Proposal

Logout if already logged in
Navigate to this link - https://staging.new.expensify.com/r/5408450846930023
Wait for the page to load completely
Verify that engagement modal is not shown for anonymous user
Login in with an existing account
Wait for the page to load completely
Verify that engagement modal is not shown

Thanks! I paid out all the offers and created the regression test issue.

Navigation Menu

Repository navigation

[HOLD for payment 2024-03-13] [$500] mWeb - Welcome to Expensify is shown for existing user after logging in from public room #35531

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

48 remaining items

Regression Test Proposal

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (!Policy.isAdminOfFreePolicy(allPolicies ?? undefined) && !isExitingToWorkspaceRoute && !hasSelectedChoice && !hasDismissedModal && Object.keys(allPolicies ?? {}).length === 1) {
	showEngagementModal();
	}

[HOLD for payment 2024-03-13] [$500] mWeb - Welcome to Expensify is shown for existing user after logging in from public room #35531

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Feb 1, 2024

melvin-bot commented on Feb 1, 2024

melvin-bot commented on Feb 1, 2024

lanitochka17 commented on Feb 1, 2024

aswin-s commented on Feb 1, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

sakluger commented on Feb 6, 2024

48 remaining items

melvin-bot commented on Mar 6, 2024

melvin-bot commented on Mar 6, 2024

melvin-bot commented on Mar 6, 2024

sakluger commented on Mar 13, 2024

situchan commented on Mar 13, 2024

Regression Test Proposal

sakluger commented on Mar 14, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions