Repository navigation
[$500] Tag - Extra padding above Recent section in Tag list #35423
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.4.33-4
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause- Internal Team
Slack conversation:
Action Performed:
Precondition:
- User is an employee of Collect workspace.
- The Collect workspace has categories and tags, each has more than 8 items in the list.
- There are recent list in Category and Tag.
- Go to workspace chat.
- Open manual request page.
- Enter amount > Next > Show more.
- Open Category and Tag list.
Expected Result:
In Tag list, there will be no extra padding above Recent, just like the Category list.
Actual Result:
There is extra padding above Recent in Tag list.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6361193_1706637788623.20240130_234328.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~019c2250ecc51e6cc7
- Upwork Job ID: 1752408936209432576
- Last Price Increase: 2024-01-30
Activity
github-actions commentedon Jan 30, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Jan 30, 2024
Triggered auto assignment to @danieldoglas (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.kbecciv commentedon Jan 30, 2024
We think that this bug might be related to #wave6-collect-submitters
CC @greg-schroeder
francoisl commentedon Jan 30, 2024
Here's production (left) vs. staging (right) side by side, it's a pretty minor gap so I'm thinking we can fix it later.
francoisl commentedon Jan 30, 2024
Yeah I'll remove the blocker label for now and open this to contribution ideas to fix. Thanks!
[-]Tag - Extra padding above Recent section in Tag list[/-][+][$500] Tag - Extra padding above Recent section in Tag list[/+]7 remaining items
FitseTLT commentedon Jan 30, 2024
@aimane-chnaif Found the offending pr. Updated proposal
FitseTLT commentedon Jan 31, 2024
@francoisl @danieldoglas @DylanDylann The root cause is found and we can fix it ASAP. WDYT
DylanDylann commentedon Jan 31, 2024
@FitseTLT's proposal looks good to me
🎀 👀 🎀 C+ reviewed
melvin-bot commentedon Jan 31, 2024
Current assignee @danieldoglas is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.
danieldoglas commentedon Jan 31, 2024
Wait, if this was caused by a recent PR (less than 7 days of the regression period), the original author of that PR needs to fix it.
danieldoglas commentedon Jan 31, 2024
cc @kubabutkiewicz can you please take a look into this, since it's still part of the regression period?
DylanDylann commentedon Jan 31, 2024
@danieldoglas Thanks for pointing out that. I will note that for next issues
situchan commentedon Jan 31, 2024
I tagged original author/reviewer already in #24921 (comment)
kubabutkiewicz commentedon Feb 1, 2024
Will create PR shortly
kubabutkiewicz commentedon Feb 1, 2024
PR ready: #35541
DylanDylann commentedon Feb 20, 2024
@danieldoglas The author of the offending PR fixed this issue. Let's close this one