Repository navigation
[$250] MEDIUM: Allow arbitrary users to be added/removed to/from workspace chat via @mention or members list #35391
Description
Activity
- changed the title
[-]Add users to workspace chat by mentioning them.[/-][+]Allow arbitrary users to be added/removed to/from workspace chat via @mention or members list[/+]on Feb 1, 2024 This has to be fixed internally, I can take this
Job added to Upwork: https://www.upwork.com/jobs/~013623b6c6ce0881ae
Triggered auto assignment to Contributor Plus for review of internal employee PR - @thesahindia (
Internal)Won't need C+ reviews for these PRs, at least for now
112 remaining items
- changed the title
[-][HOLD for payment 2024-06-24] [HOLD for payment 2024-06-06] [$500] MEDIUM: Allow arbitrary users to be added/removed to/from workspace chat via @mention or members list[/-][+][HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [HOLD for payment 2024-06-06] [$500] MEDIUM: Allow arbitrary users to be added/removed to/from workspace chat via @mention or members list[/+]on Jun 21, 2024 The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-28. 🎊
For reference, here are some details about the assignees on this issue:
- @mananjadhav requires payment through NewDot Manual Requests
- @brunovjk requires payment automatic offer (Contributor)
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@mananjadhav] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
- [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
Acknowledged! I'll issue payment on the 24th!
@johncschuster Could we get an increase in the bounty here? Mainly to cover regression. Extensive testing and adjustments were necessary during and after the PR was merged. Thank you 🙏
cc: @jasperhuangg
Reacted by Jasper Huang@brunovjk Let me check in with the team about your request. I'll follow up in a bit!
Reacted by Bruno RochaThank you :D
@brunovjk, I chatted with the team, and it seems like a regression was introduced here, which would result in a payment reduction, not an increase. Can you tell me a bit more about why you feel there should be an increase?
Thank you @johncschuster. Here's an explanation:
The initial task here was Allow arbitrary users to be added/removed to/from workspace chat via @mention or members list PR, then we had to update "who can" select/add/remove and which users can be selected/removed on workspace chats PR. That's why I asked for an increase in the reward, since this second PR involved a lot of testing and two regressions, #43828 and #42928 .
My idea was for the bounty to be $1000, minus the two regressions totalizing $250. But, I am in favor of any of your decisions.@jasperhuangg do we need to wait for #42928 to proceed with payment here?
Payment Summary:
Contributor: @brunovjk -
$1000$250 (reduced for 2x regressions) - paid via Upwork - PAID
Contributor+: @mananjadhav -$1000$250 (reduced for 2x regressions) - requires payment through NewDot Manual RequestsReacted by Bruno Rocha- changed the title
[-][HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [HOLD for payment 2024-06-06] [$500] MEDIUM: Allow arbitrary users to be added/removed to/from workspace chat via @mention or members list[/-][+][$250] MEDIUM: Allow arbitrary users to be added/removed to/from workspace chat via @mention or members list[/+]on Jun 28, 2024 Upwork job price has been updated to $250
@mananjadhav, can you propose a regression test checklist?
@johncschuster I think the test steps from the PR here. I are good for the checklist. Can we please use that?
Pre-condition:
1. We need 4 accounts for this test:
- Workspace Creator
- Workspace Admin
- Workspace Member
- No-workspace member (invited)
2. Login in the app as "Workspace Creator"
3. Create a workspace
4. Go to the automatically created "Workspace Chat"
5. Go to the "Report Details"
6. Go to "Members" page Click "Invite"
7. Invite all the other 3 accounts (admin,member, andinvited) to the "Workspace Chat"
8. Still on the "Members" page, change theadminrole toAdministrator8. Click on the "Global Fab" "Start Chat" Select "#Room" tab
9. Create a "workspace-room"
10. Invite all the other 3 accounts (admin,member, andinvited) to the "workspace-room"Tests:
1. Logged as the "Workspace Creator":
i. Go to the "Workspace Chat" Report Details page
ii. Verify that the "Leave" button doesn't show, as you are a "workspace admin".
iii. Go to "Members" page
iv. Verify that you cannot select/remove admin and default added members
v. Verify that you can "Invite" and "Remove" (admin cannot be removed) members
vi. Go to the "workspace-room" Report Details page
vii. Go to "Members" page
viii. Verify that you can "Invite" and "Remove" (you cannot remove yourself here) members2. Logged as the "Workspace Admin":
i. Go to the "Workspace Chat" Report Details page
ii. Verify that the "Leave" button doesn't show, as you are a "workspace admin".
iii. Go to "Members" page
iv. Verify that you cannot select/remove admin and default added members
v. Verify that you can "Invite" and "Remove" (admin cannot be removed) members
vi. Go to the "workspace-room" Report Details page
vii. Go to "Members" page
viii. Verify that you can "Invite" and "Remove" (you cannot remove yourself here) members3. Logged as the "Workspace Member":
i. Go to the "Workspace Chat" Report Details page
ii. Verify that the "Invite" button does not show.
iii. Go to "Members" page
iv. Verify that you cannot "Invite" and "Remove" members.
v. Logged as the "Workspace Member" Go to the "workspace-room" Report Details page
vi. Verify that the "Invite" button does not show.
vii. Go to "Members" page
viii. Verify that you can "Invite" and "Remove" (you cannot remove yourself here) members.4. Logged as the "Workspace Chat Invited":
i. Go to the "Workspace Chat" Report Details page
ii. Verify that the "Invite" button does not show.
iii. Go to "Members" page
iv. Verify that you cannot "Invite" and "Remove" members.
v. Logged as the "Workspace Room Invited" Go to the "workspace-room" Report Details page
vi. Verify that the "Invite" button does show and you can invite members to the chat.Reacted by John Schuster$250 approved for @mananjadhav
Problem:
Right now there are no possibilities to add anyone to the automatically created workspace chats, but it should be possible to add by "mention"; it's similarly not possible to remove someone who has been thus added.
Solution:
As discussed here, we would like to add this possibility to:
Invitebutton of the members pageIMPORTANT details for workspace chats:
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @johncschuster