[HOLD for payment 2024-02-20] [$500] Android - Room-Invited room avatar looks different

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.32
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap on a room chat
3. Tap header--- members-- invite a user X
4. Launch app
5. Login as user X in Android app
6. Tap on invited room chat
7. Tap on header -- avatar

Expected Result:

Invited room avatar must be shown correctly

Actual Result:

Invited room avatar looks different ( like placeholder)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6355985_1706287071557.full.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01220f7073da90ab3b
• Upwork Job ID: 1750958302280990720
• Last Price Increase: 2024-01-26
• Automatic offers:
• tienifr | Contributor | 28133955

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01220f7073da90ab3b

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Invited room avatar looks different ( like placeholder)

What is the root cause of that problem?

In here, we're not using the ReportUtils.getPolicyName method to get the policy name.

When user is a member of the room but is not a member of the workspace, they will not have access to the policy data. So the policy?.name used here will be empty.

In this case, the right thing to do is to fallback to the report's report?.policyName, which is what ReportUtils.getPolicyName already handled for us (along with a few other cases).

So it couldn't find the policyName and will fallback to the default avatar (instead of the avatar with workspace initial as it should be).

What changes do you think we should make in order to solve the problem?

In here, use the ReportUtils.getPolicyName method to get the policy name.

const policyName = ReportUtils.getPolicyName(report, false, policy);

(Can consider passing returnEmptyIfNotFound param as true, but false is generally used in such icon-getting logic)

Optionally, in here, we should use the getWorkspaceAvatar since it's a proven method for retrieving the workspace avatar. To be safe, we can pass the policy as a second param into getWorkspaceAvatar and use it instead of getting from allPolicies, if the param is passed in (just like what we did with getPolicyName)

What alternative solutions did you explore? (Optional)

Unrelated, but there's a report.policyAvatar field that was recently added from the back-end to fix another issue, and the front-end changes for that is already being handled via this PR. It will fix some use cases related to the policy avatar but not directly related to this issue. If any additional change related to the report.policyAvatar (like same change for getWorkspaceAvatar), it should be handled in that PR as well.

[Tony-MK]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - Room-Invited room avatar looks different

What is the root cause of that problem?

No policy record associated with the room is stored in the onyx because the user was not invited to the policy but to the policy room.

App/src/libs/ReportUtils.ts

Lines 1443 to 1446 in c5ca9a8

	const policyExpenseChatAvatarSource = allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${report?.policyID}`]?.avatar
	? allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${report?.policyID}`]?.avatar
	: getDefaultWorkspaceAvatar(workspaceName);

Hence, in the getWorkspaceIcon function, the value of policyExpenseChatAvatarSource will be the default icon of the room.

However, The correct workspace avatar source is stored in the policyAvatar attribute is available in the report, but we are not utilizing it in the getWorkspaceIcon.

What changes do you think we should make in order to solve the problem?

We should also check if the report?.policyAvatar is present after the policy fails to be found in the Onyx collection and before it calls getDefaultWorkspaceAvatar.

Therefore, let's change the code snippet mentioned above to modify the getWorkspaceIcon function like below.

const policyExpenseChatAvatarSource = allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${report?.policyID}`]?.avatar
  ? allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${report?.policyID}`]?.avatar : report?.policyAvatar;

const workspaceIcon: Icon = {
    source: policyExpenseChatAvatarSource ?? getDefaultWorkspaceAvatar(workspaceName) ?? '',
    ....

Extras

1. Change the getWorkspaceAvatar function as well for consistency.
2. Add policyAvatar to the Report type due to typescript errors.

[tienifr]

@Tony-MK Just FYI the report.policyAvatar was recently added from the back-end to fix another issue, and the front-end changes you suggested is already being handled via this PR, if any additional change related to the report.policyAvatar, it should be handled in that PR as well.

Proposal updated to mention this additional information.

[Christinadobrzyn]

reviewing proposals