Repository navigation
[HOLD FOR #23546][$500] mWeb - PDF - When typing password, revealing it and confirm, another attachment is displayed #35197
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.32-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4238270
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Pre-requisite: the user must be logged in.
- Go to any chat.
- Send a password protected PDF.
- Send another attachment.
- Tap on the password protected PDF preview.
- Type the password.
- Tap on the eye icon button to reveal it (Important step).
- Tap on "Confirm".
Expected Result:
The password protected PDF should be displayed.
Actual Result:
Another file is displayed.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6355154_1706218295008.Xfnu9744_1_.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~014ec322edab15924f
- Upwork Job ID: 1750639602223542272
- Last Price Increase: 2024-02-08
Activity
melvin-bot commentedon Jan 25, 2024
Job added to Upwork: https://www.upwork.com/jobs/~014ec322edab15924f
[-]mWeb - PDF - When typing password, revealing it and confirm, another attachment is displayed[/-][+][$500] mWeb - PDF - When typing password, revealing it and confirm, another attachment is displayed[/+]melvin-bot commentedon Jan 25, 2024
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jan 25, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (
External)kbecciv commentedon Jan 25, 2024
We think that this bug might be related to #vip-vsb
CC @quinthar
jeremy-croff commentedon Jan 26, 2024
Seems like a side effect of #23546
I noticed it diddn't even open the correct image on initial load.
ikevin127 commentedon Jan 26, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue
Another file is displayed after inputting the password for a password protected pdf file, tapping the reveal password "Eye" then pressing the Confirm.
What is the root cause of that problem?
I found the culprit, the line which for some weird unknown reason causes this issue, only after tapping the reveal password "Eye" then pressing the Confirm button. It was introduced by this PR #26025 and this is the line:
App/src/components/PDFView/PDFPasswordForm.js
Lines 145 to 146 in 1439ac0
I know this is not enough to pass as an acceptable RCA since the reason why it's only happening when the reveal password "Eye" is tapped, is still unknown. But since I found a solution to the issue I thought I should mention it 🌞
What changes do you think we should make in order to solve the problem?
Removing the line mentioned above fixes the issue but that wound also mean removing the functionality added by the mentioned PR which is: keyboard should stay open (keeping input focused) when clicking the Confirm button.
If we really want this fixed even though the full root cause is unknown, and we're fine with not having the "keyboard should stay open" functionality on iOS: mWeb Safari - we can create a library that will target only iOS: mWeb Safari, keeping the PR's functionality for all other platforms while fixing the current issue in Safari.
Videos
iOS: mWeb Safari
Screen.Recording.2024-01-26.at.16.34.53.mov
Screen.Recording.2024-01-26.at.16.36.06.mov
MacOS: Safari
Screen.Recording.2024-02-05.at.17.23.07.mov
Screen.Recording.2024-02-05.at.17.24.38.mov
c3024 commentedon Jan 29, 2024
Thanks for digging.
That did work. Let's see if we can identify the root cause.
48 remaining items
CortneyOfstad commentedon Apr 29, 2024
PR is still in review 👍
CortneyOfstad commentedon May 6, 2024
Bumped a comment on the PR here
CortneyOfstad commentedon May 10, 2024
PR is continuing to be reviewed with comments as recent as <2 hours ago 👍
CortneyOfstad commentedon May 15, 2024
PR has been reviewed and should be marked for merging based on the comment here
CortneyOfstad commentedon May 20, 2024
We're on a merge freeze until Wednesday, so this will be delayed 👍
CortneyOfstad commentedon May 22, 2024
Merge freeze should end today 🤞
CortneyOfstad commentedon Jun 3, 2024
Went into product:ion 4 days ago! 😍
CortneyOfstad commentedon Jun 6, 2024
On hold issue has been resolved/completed, so this can be closed! 🎉