Repository navigation
Distance - No error message when saving duplicate points #35193
Description
Activity
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
Triggered auto assignment to @francoisl (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.We think that this bug might be related to #wave6.
CC @greg-schroederhmm I think this is closer to Wave 5
Production doesn't let you save the duplicate waypoints either, but at least shows an error message
Please select unique waypoints.:
I think that's really the regression here that's not working on staging. That error message is correctly returned by the API to the
UpdateMoneyRequestDistancerequest on staging too, e.g.:{ "code": 666, "jsonCode": 666, "type": "Expensify\\Libs\\Error\\ExpError", "UUID": "80DA580D-B8AD-4E6E-B23D-7E25E9A8318A", "message": "Please select unique waypoints.", "title": "", "data": [], "htmlMessage": "", "onyxData": [], "requestID": "84b3ea47dbc6270a-SJC" }Screen.Recording.2024-01-25.at.2.18.53.PM.mov
@aldo-expensify reverting #34107 locally fixes the issue - any idea about a quick solution we could apply instead of reverting?
Ok I think I see the issue, it's a backend fix so we'll keep it internal.
Job added to Upwork: https://www.upwork.com/jobs/~01c1a743dc1fab2180
Triggered auto assignment to Contributor Plus for review of internal employee PR - @allroundexperts (
Internal)No need for a C+ here, thanks!
A backend fix was merged, we're not going to CP it given that this is a fairly small issue in the end.
This has been fixed and deployed for a while, forgot to close.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.32-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Issue found when executing PR #34107
Action Performed:
Expected Result:
App will throw the error "Please select unique waypoints"
Actual Result:
No error message is seen when saving duplicate waypoints
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6355111_1706215612433.20240126_022216.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit