[$500] Task is not archived when delete WS Offline

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.32-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #31900

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in
3. Create a new workspace
4. Open the workspace/policy expense chat
5. Create a thread
6. Turn off the internet connection
7. Delete the workspace

Expected Result:

Thread is archived

Actual Result:

Thread is not archived when delete WS Offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6354970_1706205858291.Thread_is_not_archived_when_delete_WS_Offline.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0148ea2ff5d6b35fdb
• Upwork Job ID: 1750595971529564160
• Last Price Increase: 2024-01-25
• Automatic offers:
• aimane-chnaif | Reviewer | 28148967
• mkhutornyi | Contributor | 28148968

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0148ea2ff5d6b35fdb

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[kbecciv]

We think that this bug might be related to #vip-vsb
CC @quinthar

[Tony-MK]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - The task does not display in LHN that it is archived

What is the root cause of that problem?

We checked if the report is a ReportUtils.isThread(report) and removed it from the list of workspace reports that need to be archived.

App/src/pages/workspace/WorkspaceInitialPage.js

Lines 103 to 105 in 889051c

	if (!report.reportID || ReportUtils.isThread(report)) {
	return;
	}

Setting the reports attribute statusNum and stateNum in the deleteWorkspace function.

What changes do you think we should make in order to solve the problem?

Remove the condition ReportUtils.isThread(report) and leave the condition checking the report, which has an Id (!report.reportID).

[ra-md]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The thread is not archived when we delete WS in Offline mode.

What is the root cause of that problem?

The thread is actually archived, but we just don't add an "archived" indicator for threads in the LHN. Here, we don't check if the parent report is archived.

What changes do you think we should make in order to solve the problem?

we can add a condition like here to check if the parent report is archived and add Localize.translateLocal('common.archived') after parentReportActionMessage to show that the thread has been archived.

What alternative solutions did you explore? (Optional)

N/A

[aimane-chnaif]

Proposals are in review