[HOLD for payment 2024-10-17] [HOLD for payment 2024-10-10] [Simple AA in NewDot] [HIGH] Improve how we handle auto-submission in NewDot

@tylerkaraszewski

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v1.4.33-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @tylerkaraszewski
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1706118036323349

Action Performed:

Prerequisites:
use a collect policy
has scheduled submit enabled
has access to the isPolicyExpenseChatEnabled beta.

Request money from the collect workspace
Wait until the report is auto-submitted (i.e end of the day if set to Daily)
Observe the Submit button is still present on the report preview for the submitter, despite it being submitted.
Observe the submitted $x.xx via Scheduled Submit reportAction is not added to the expense report
Sign-in as the approver
Observe the workspace chat is not unread for the approver, the LHN does not contain a GBR green dot and the preview component doesn't contain an approve button.

Expected Result:

On auto-submission, the the submit button should be removed.
The NewDot reportAction for autoSubmission should be added to the chat from the submitter, the OldDot one from Concierge should not appear in NewDot.
On auto-submission of the report, the workspace chat should be unread for the approver, the LHN chat row should have a GBR green dot and an approve button should be in the preview component.

Actual Result:

The submit button is visible and clickable
The NewDot reportAction is not added to the report, just the OldDot one.
The approver isn't notified (chat is not unread, no GBR applied, no approve button on the preview)

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?
All

Screenshots/Videos

Add any screenshot/video evidence

Submit button still visible:
https://github.com/Expensify/App/assets/43996225/f09c69e2-434c-4205-9949-1457cfee28fa

OldDot reportAction appearing not the NewDot one

Chat not unread, no GBR on the chat row in the LHN
To be added

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01aa9178aa3b2044ea
Upwork Job ID: 1760318902746746880
Last Price Increase: 2024-02-21

Issue Owner

Current Issue Owner: @trjExpensify

@trjExpensify

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Asking a few Qs: https://expensify.slack.com/archives/C049HHMV9SM/p1706123412357589?thread_ts=1706118036.323349&cid=C049HHMV9SM

Tyler couldn't reproduce this issue. He did run into a different bug with not being able to delete an expense off a processing report, but that's totally different and being figured out over here.

@tylerkaraszewski

I think the issue involves auto-submission. I've noticed that when the report has already been auto-submitted and then I try to submit again. @tylerkaraszewski, do you see any system messages when clicking into the report preview?

Discussion for ref.

@mountiny

Spruced this up in-line with the thread discussion. @mountiny are you taking this one?

@mollfpr

$750 approved for @mollfpr based on this summary

@mollfpr

@mollfpr I'm not following this test "auto-approval and auto-forwarding"? If auto-approval is enabled in that case, why is the report action approved <amount>?

@trjExpensify

@trjExpensify I believe Employee C can't auto-approve the expense and the report action is expected to approved <amount>. Is that answer your question?

Huh, why not? 🤔 If auto-approval is enabled and the report isn't flagged for review because of the amount and/or random audit percentage, it should be final approved.

@Beamanator

Maybe @Beamanator can help to answer it 😅

From your above comment, I have the same thought now.

Huh, Idk if I wrote that initially but I'd definitely expect that to say "automatically approved ${amount} via <a href="${CONST.CONFIGURE_REIMBURSEMENT_SETTINGS_HELP_URL}">workspace rules</a>,"

Code ref:

App/src/libs/OptionsListUtils.ts

Line 638 in 7b9a0cd

    
           lastMessageTextFromReport = ReportUtils.getReportAutomaticallyApprovedMessage(lastReportAction);

@mollfpr

Okay, @mollfpr can we modify the tests then? Do we scrap that second one completely or what else are we including it for?

@trjExpensify

@trjExpensify I have updated step 5 on auto approved and auto forwarding test case. The expected result on "auto approved" is the same as the first auto-approved test case, and the approved <amount> is shown after the forwarder approves the expense.

Sorry, I still don't get it. When auto-approval is enabled, the report is auto-approved at every step in the approval chain, not just the first one. So how is this happening and/or an accurate test?

auto-approval and auto-forwarding

Set up Control policy on NewDot, with Advanced Approvals enabled - non instant submit

Make sure the policy has at least 3 members, where at least one employee has an approval chain like this:

Employee A submitsTo Employee B

Employee B forwardsTo Employee C

In OldDot as the policy admin, enable auto approvals

In the workspace Members page, set Manually approve all expenses over: to something like $1000

Set Randomly route reports for manual approval: to 0%

In NewDot, have Employee A submit an expense in their workspace chat

Verify the expense is auto approved from Employee B and the text on LHN and report actions is automatically approved $<amount> via workspace rules

On Employee C, open the workspace chat for Employee A and verify an expense submitted from Employee A is forwarded to Employee C

Approved the expense

Verify the text on LHN and report action is approved <amount>

oh uhhhhh we might not have built multi-auto-approvals yet 🙃 https://github.com/Expensify/Expensify/issues/434467

@mollfpr

oh uhhhhh we might not have built multi-auto-approvals yet 🙃 https://github.com/Expensify/Expensify/issues/434467

Wowza, I did not know that. So then I don't think we add a test for the temporary behaviour. Rather, when we add support for auto-approval with multi-level approvals, add a test then to verify both levels are auto-approved.

I've gone ahead and created a GH for 1, 2 and 4 above for now.

Go ahead and request $750 on the basis of this payment summary, @mollfpr. Closing!

Navigation Menu

Repository navigation

[HOLD for payment 2024-10-17] [HOLD for payment 2024-10-10] [Simple AA in NewDot] [HIGH] Improve how we handle auto-submission in NewDot #35091

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

210 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-10-17] [HOLD for payment 2024-10-10] [Simple AA in NewDot] [HIGH] Improve how we handle auto-submission in NewDot #35091

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jan 24, 2024

trjExpensify commented on Jan 24, 2024

trjExpensify commented on Jan 29, 2024

luacmartins commented on Jan 30, 2024

trjExpensify commented on Jan 30, 2024

trjExpensify commented on Jan 30, 2024

210 remaining items

garrettmknight commented on Oct 29, 2024

trjExpensify commented on Nov 1, 2024

mollfpr commented on Nov 1, 2024

trjExpensify commented on Nov 1, 2024

mollfpr commented on Nov 5, 2024

Beamanator commented on Nov 6, 2024

trjExpensify commented on Nov 12, 2024

mollfpr commented on Nov 14, 2024

trjExpensify commented on Nov 15, 2024

Beamanator commented on Nov 15, 2024

trjExpensify commented on Nov 19, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions