[$500] mweb/Chrome - Expense - App returns to LHN when tapping back button after refreshing request page

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.31-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #34236

Action Performed:

Go to workspace chat
Create a manual request
Go to request details page
Refresh the page
Tap on the back button

Expected Result:

App returns to expense report

Actual Result:

App returns to LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6353492_1706117862008.1000009580.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0183615511eed125fe
Upwork Job ID: 1750220362340155392
Last Price Increase: 2024-02-14

Job added to Upwork: https://www.upwork.com/jobs/~0183615511eed125fe

@NicMendonca

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@parasharrajat

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - App returns to LHN when tapping back button after refreshing request page

What is the root cause of that problem?

It is because ROUTES.HOME is our fallback here

App/src/components/MoneyRequestHeader.js

Lines 139 to 140 in 74f1163

    
               onBackButtonPress={() => Navigation.goBack(ROUTES.HOME, false, true)} 
        
           />

What changes do you think we should make in order to solve the problem?

We should give the parentReport route as a fallback

                    onBackButtonPress={() => Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(parentReport.reportID), false, true)}

What alternative solutions did you explore? (Optional)

@FitseTLT

Hmm! These kinds of issues are always a headache.

@FitseTLT Can you try playing around with different ways of navigation and see what is expected from this button in those cases.

It would be great if you can present that list here.

different ways of navigation

????

Try navigating to expense reports in different ways.

Directly via URL.
On Large screens Web.
ON smaller screens.
Via deeplink.

etc.

Directly via URL - It should go back to the parent report
On Large screens Web - It doesn't display so no worries here
ON smaller screens - It applies to small screens only 👍
Via deeplink ( I assume the link was a message on another report chat) - it should go back to the original report from which the link was clicked.

The only odd case is (4). If we should consider achieving that we need to pass as a fallback route the previous screen/route and if it doesn't exist (in the case of refreshing the page ) we will fallback to the parent report.

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@sonialiap

@sonialiap, @parasharrajat 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@parasharrajat

I can take over while @parasharrajat is unavailable https://expensify.slack.com/archives/C02NK2DQWUX/p1707413964286239

I think we should hold for #36050, maybe this PR resolves the issue

@sonialiap

@sonialiap Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@sonialiap

@sonialiap this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@sonialiap

@sonialiap Eep! 4 days overdue now. Issues have feelings too...

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

I cannot reproduce. I think #36050 may have solved this. Please reopen if you can reproduce

Navigation Menu

[$500] mweb/Chrome - Expense - App returns to LHN when tapping back button after refreshing request page #35084

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

15 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	onBackButtonPress={() => Navigation.goBack(ROUTES.HOME, false, true)}
	/>

[$500] mweb/Chrome - Expense - App returns to LHN when tapping back button after refreshing request page #35084

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jan 24, 2024

melvin-bot commented on Jan 24, 2024

melvin-bot commented on Jan 24, 2024

FitseTLT commented on Jan 24, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

parasharrajat commented on Jan 24, 2024

FitseTLT commented on Jan 24, 2024

parasharrajat commented on Jan 24, 2024

FitseTLT commented on Jan 24, 2024

15 remaining items

melvin-bot commented on Feb 7, 2024

melvin-bot commented on Feb 8, 2024

ishpaul777 commented on Feb 8, 2024

ishpaul777 commented on Feb 9, 2024

melvin-bot commented on Feb 12, 2024

melvin-bot commented on Feb 14, 2024

melvin-bot commented on Feb 14, 2024

melvin-bot commented on Feb 14, 2024

sonialiap commented on Feb 15, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions