Widespread Android Exception: Cannot read property 'push' of undefined

[Julesssss]

Problem

@Expensify/mobile-deployers

There seems to be a new crash in NewDot a recent release. The email mentions version 1001043102, but this actually started occuring in version 1001042900 1.4.29-0, which was a couple of releases ago... was the Firebase checkist step missed somehow?

Here's the Firebase exception & stack trace:

Fatal Exception: com.facebook.react.common.JavascriptException: TypeError: Cannot read property 'push' of undefined, js engine: hermes, stack:
use@1:2023797
anonymous@1:2064016
loadModuleImplementation@1:162235
guardedLoadModule@1:161468
metroRequire@1:160751
anonymous@1:2061618

I'm sick today and just completing chores, so can't spend any more time here. I didn't add the blocker label as this has existed in two prior versions, but we may want to block the next release until this is resolved as it seems pretty bad.

Solution

Locate the issue that introduced this.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0131326c989b3bc942
• Upwork Job ID: 1750109819789500416
• Last Price Increase: 2024-01-24

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0131326c989b3bc942

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @eVoloshchak (Internal)

[situchan]

@Julesssss this is deploy blocker, came from #32326 (comment)

[situchan]

reverting here

[Julesssss]

Ah thank you

[Julesssss]

Okay, so we're all good here. We need to improve our Firebase exception though, as this major regression is currently on prod. I'll leave the issue open for a bit in case anyone has any suggestions.

If we had time, showing all newly occurring exceptions in the checklist would be a nice improvement. We could then require manual review and comment for each new exception.

[thienlnam]

We need to improve our Firebase exception though, as this major regression is currently on prod

I believe this only made it to staging, the PR that introduced the crashes were added to staging - crashing was found and then reverted in this same deploy #35037

I also handled the deploy yesterday, and this specific crash did not show up on firebase