Skip to content

[HOLD for payment 2024-03-18] [HIGH] [Instant Submit] for Collect: Improve creating expenses on Instant Submit paid plans, from NewDot #34955

Closed

Description

@Beamanator

Holding on https://github.com/Expensify/Expensify/issues/360667

Instant Submit for Collect Workspaces Design Doc

Tracking GH issue: https://github.com/Expensify/Expensify/issues/334111

Goal for this issue: Make sure these flows work perfectly in NewDot, for Paid plans on Instant Submit

  1. In Workspace chat, click report preview of a report to open the expense report
  2. Request money (this currently isn't possible for submitted reports, in NewDot)
  3. Verify the request / expense gets added to that correct expense report
  4. Navigate back to the workspace chat & request money there
  5. Verify the request / expense gets added to the most recently created expense report
    1. It looks like we currently optimistically try to find an OPEN report in NewDot to add a money request to & if we don't find one, we optimistically create a new Report Preview. We will need to update this to look for Processing as well, only if the policy is Instant Submit!
    2. We're also having a discussion about "do we need this to be added to the most recent expense report or any" in slack here.
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f9e4f88d7ec8247b
  • Upwork Job ID: 1749734239297155072
  • Last Price Increase: 2024-01-23
Issue OwnerCurrent Issue Owner: @garrettmknight

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    on Jan 23, 2024
  2. melvin-bot commented on Jan 23, 2024

    @melvin-bot
  3. melvin-bot commented on Jan 23, 2024

    @melvin-bot

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @hoangzinh (Internal)

  4. Beamanator commented on Jan 25, 2024

    @Beamanator
    ContributorAuthor

    Technically all backend changes are ready on staging, so I'll take this off hold soon!

  5. changed the title [-][HOLD E/E#360667] [Instant Submit for Collect] CRITICAL: Allow creating expenses on Instant Submit paid plans, from NewDot[/-] [+][HOLD E/E#360667] [Instant Submit for Collect] CRITICAL: Improve creating expenses on Instant Submit paid plans, from NewDot[/+] on Jan 25, 2024
  6. changed the title [-][HOLD E/E#360667] [Instant Submit for Collect] CRITICAL: Improve creating expenses on Instant Submit paid plans, from NewDot[/-] [+][Instant Submit for Collect] CRITICAL: Improve creating expenses on Instant Submit paid plans, from NewDot[/+] on Jan 26, 2024
  7. added
    Hot PickReady for an engineer to pick up and run with
    on Jan 26, 2024
  8. Beamanator commented on Jan 26, 2024

    @Beamanator
    ContributorAuthor

    Looking for volunteer via Hot Pick label

  9. self-assigned this
    on Jan 26, 2024
  10. 39 remaining items

  11. garrettmknight commented on Mar 11, 2024

    @garrettmknight
    Contributor

    Assigning myself to handle BZ stuff.

  12. garrettmknight commented on Mar 15, 2024

    @garrettmknight
    Contributor

    Updating to daily to pay on Monday. @hoangzinh are you getting paid via NewDot these days? Linking SO to for myself update if you are.

  13. hoangzinh commented on Mar 15, 2024

    @hoangzinh
    Contributor

    Hi @garrettmknight nope, I'm still getting paid via Upwork 😢

  14. garrettmknight commented on Mar 15, 2024

    @garrettmknight
    Contributor

    Bummer - offer is out to you!

  15. hoangzinh commented on Mar 15, 2024

    @hoangzinh
    Contributor

    Accepted. Thanks @garrettmknight

  16. garrettmknight commented on Mar 18, 2024

    @garrettmknight
    Contributor

    Paid, closing

  17. moved this from Release 1: Spring 2024 (May) to Done in [#whatsnext] #wave-collecton Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2InternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions