Repository navigation
[Hold #41442] [Guided Setup Stage 3][$500] Don't create default #announce rooms until a workspace has 3 or more members #34929
Description
Problem
While we originally envisioned default rooms to streamline the a whole host of team collaboration use cases – including announcements to your employees, or chatting with other admins - as we've gained experience onboarding users to NewDot we've realized that this has had the effect of making onboarding harder. More specifically, your LHN starts out with a host of rooms and messages, though it's not clear which you should start with first:
- Expensify (planned)
- Concierge
- Workspace chat
- #admins
- #announce
Even further, plenty of sign-ups are first and foremost looking for an expense and financial management app, and they're just one person, so this ends up confusing them that they've downloaded the wrong app, costing us valuable bottom-up chances that we'd otherwise keep around as long as sign-ups can effectively find what they're looking for.
Solution
Part of this solution is more targeted onboarding, and that's already being worked on in #wave9-collect-signups. Though equally, let's not assume group collaboration is what sign-ups are after – especially if they're the only member of the workspace. A good example is the #announce room, which is only relevant when a workspace has several members.
Thus, in an effort to simplify what users are exposed to post-sign-up, and better target our functionality to their intended use case, let's:
- Not create a default #announce room when the workspace is created
- Instead, let's only create #announce rooms when the third member is added to the workspace (after all, otherwise two members could use a DM without issue).
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01d20cdc896fd34ad2
- Upwork Job ID: 1755964549843316736
- Last Price Increase: 2024-02-16
- Automatic offers:
- rojiphil | Contributor | 0
Activity
melvin-bot commentedon Jan 22, 2024
Triggered auto assignment to @sophiepintoraetz (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.melvin-bot commentedon Feb 1, 2024
Triggered auto assignment to @johncschuster (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.153 remaining items
trjExpensify commentedon Sep 20, 2024
What's the announce room used for in that invoice case, @madmax330?
madmax330 commentedon Sep 20, 2024
Apparently nothing 😄
Or if something I can't find it.
But I think it's mainly because we create the room optimistically, so when the API doesn't create it it causes a bug on the front-end. So maybe we should just stop creating it altogether?
anmurali commentedon Sep 23, 2024
https://fsty.io/v/6X2rBN3K
I have seen this in about a dozen sessions. The #announce room shows up but when clicked shows a not here error. Is this because the room is created optimistically? I think we should just stop creating it. Create it when there are 3+ members in the workspace.
trjExpensify commentedon Sep 23, 2024
That's already the plan, isn't it? The App PR is in review: #48660
danielrvidal commentedon Sep 26, 2024
I'd vote we stop creating it altogether. I saw this in 3 full stories impacting customers trying to adopt. Can we prioritize as CRITICAL?
trjExpensify commentedon Sep 26, 2024
Yeah, I think we still need this App PR to be merged: #48660
JmillsExpensify commentedon Sep 26, 2024
Agreed. Can we update that PR to CRITICAL, mostly because it's affecting production users. What do ya'll think @NikkiWines @allroundexperts?
trjExpensify commentedon Sep 26, 2024
Ah yeah, I commented in the PR already. I've escalated it to slack here: https://expensify.slack.com/archives/C02NK2DQWUX/p1727347525853669
melvin-bot commentedon Sep 30, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
NikkiWines commentedon Oct 11, 2024
This can be closed I think - #48660 has been on prod for a few weeks now - not sure why the issue wasn't updated with the payment details.
@johncschuster can we issue payment to @rojiphil and @allroundexperts for the PR and C+ review - thank you 🙇
johncschuster commentedon Oct 14, 2024
Payment Summary:
Contributor: @rojiphil paid $500 via Upwork - PAID! 🎉
Contributor+: @allroundexperts due $500 via NewDot
Upwork job here! Please applymelvin-bot commentedon Oct 22, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
JmillsExpensify commentedon Feb 13, 2025
$500 approved for @allroundexperts