[HOLD for payment 2024-02-01] When Paying with Expensify the passed payment type is REPORT

[mountiny]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

It seems like this is broken since #34621

Version Number: v1.4.29-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @joekaufmanexpensify @johnmlee101
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1705929941791079

Action Performed:

Break down in numbered steps

You should have wallet enabled, for testing purposes I think you can bypass the KYC

1. Submit request to account that already has an upgraded wallet.
2. Click into the Request.
3. Click Pay with Expensify.

Expected Result:

Describe what you think should've happened

Payment goes through

Actual Result:

Describe what actually happened

Error appears because the

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Current assignee @mountiny is eligible for the Engineering assigner, not assigning anyone new.

[mountiny]

From the logs we can see that the problem is that in here the payment type is REPORT for some unclear reason so then the api method called is the PayMoneyRequest which is not correct for the Pay with Expensify option

[mountiny]

Seems like ti started after this deploy #34621 as only the deploy before is the last one this worked

[mountiny]

This is not technically a deploy blocker, but important flow that is not yet covered by regression testing that is broken so trying to fix with urgency

[ZhenjaHorbach]

I think the problem related to this changes
#33714 (comment)