[HOLD 34424] Chat - Not here page shows up when thread loads after joining and leaving thread offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.26-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #34376

Action Performed:

1. Go offline
2. Send a message
3. Right click on message > Unsubscribe from thread
4. Right click on message > Reply in thread.
5. Click Join
6. Click 3-dot menu > Leave
7. Right click on message > Reply in thread
8. Click on the header subtitle to return to main chat
9. Right click on message > Reply in thread
10. Go online.

Expected Result:

Thread view loads successfully.

Actual Result:

Not here page shows up

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6345375_1705504215369.bandicam_2024-01-17_21-01-15-686.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mountiny]

@paultsimura @srikarparsi Could you check this one out, seems like a regression from the PR you have worked on possibly, but it and edgecase that i dont think this has to be a blocker

[srikarparsi]

Yeah agree, it does seem like a regression from #34376, I can take this one @AndrewGable

[paultsimura]

Hey @srikarparsi @mountiny, fortunately (for me 🙂) it's not a regression from our PR. We just enabled the "Leave" button on empty threads and made this bug a bit easier to catch. Also, it wasn't technically a Deploy Blocker.

I reverted the PR, and was able to reproduce the same bug with one extra step: need to add a reply in the thread before leaving it (it changes nothing, just shows the "leave" button because the thread becomes non-empty):

Screen.Recording.2024-01-18.at.10.12.14-compressed.mp4

I think this falls more into the scope of #34424

[mountiny]

Thanks! I agree its not direct regression but should be looked at