Repository navigation
Remove MoneyRequestParticipantsSelector.js and copy any changes since Nov 27 into MoneyTemporaryForRefactorRequestParticipantsSelector #34617
Description
This is a part of #29107. You can look at that issue for more context behind the cleanup process.
Problem
The app has two redundant components:
Old Component: MoneyRequestParticipantsSelector
New Component MoneyTemporaryForRefactorRequestParticipantsSelector
Solution
Following the examples (example 1, example 2), the Old Component needs to be completely removed from the codebase
- Look at the history of the Old Component
- If there are any changes since Nov 27, 2023 which have not been added to the New Component, copy those changes
- Replace all uses of the Old Component with the New Component
- Remove all traces of Old Component
- Be sure to update all routes and navigation to use the new
:actionparam (instead of being hard-coded with"create") - Update any logic like
isEditingto use the new action param from the route
Activity
melvin-bot commentedon Jan 16, 2024
Triggered auto assignment to @kevinksullivan (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.KrAbhas commentedon Jan 16, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Remove MoneyRequestParticpantsSelector.js and copy any changes since Nov 27 into MoneyTemporaryForRefactorRequestParticipantsSelector.js
What is the root cause of that problem?
Cleaning of MoneyRequestParticpantsSelector
What changes do you think we should make in order
We will be deleting the component here:
App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js
Line 73 in a7a3e7f
This component appears in MoneyRequestParticipantsPage which will also be removed
App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js
Line 24 in a7a3e7f
Looking at the changes in history we can see a quiet a few commits made after Nov 27. On further analysis, some of the changes are already in
MoneyTemporaryForRefactorRequestParticipantsSelector. We will go commit by commit and add the remaining necessary logic to MoneyTemporaryForRefactorRequestParticipantsSelectornjmulsqb commentedon Jan 17, 2024
I would love to take this!
melvin-bot commentedon Jan 17, 2024
Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.
melvin-bot commentedon Jan 17, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (
External)MahmudjonToraqulov commentedon Jan 17, 2024
I would love to take this!
dummy-1111 commentedon Jan 17, 2024
I would love to take this!
79 remaining items
DylanDylann commentedon Apr 20, 2024
@dangrous The guideline in the description isn't correct. We have a Slack thread to discuss it before.
DylanDylann commentedon Apr 23, 2024
Waiting for the response from @dangrous
DylanDylann commentedon Apr 23, 2024
Oh wait, It seems MoneyRequestParticipantsSelector is removed somewhere so let's close this one
DylanDylann commentedon Apr 24, 2024
@kevinksullivan This issue is outdated now, let's close this one
dangrous commentedon Apr 26, 2024
Yep you're right, looks like that component is gone now. However we still have the weirdly named
MoneyTemporaryForRefactorRequestParticipantsSelector.js- do we know if there's a plan to change that?brunovjk commentedon Apr 26, 2024
@dangrous Yes we have. Pasyukevich from Callstack will migrate to TS and rename: #29107 (comment)
dangrous commentedon Apr 26, 2024
Got it, thanks! So @kevinksullivan if you agree I think we can close this, as @DylanDylann suggests
melvin-bot commentedon Apr 30, 2024
@dangrous, @kevinksullivan, @DylanDylann Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
kevinksullivan commentedon Apr 30, 2024
Sounds good 👍