[Pay 4/29][$250] Remove NewDistanceRequestPage.js and copy any changes since Nov 27 into IOURequestStepDistance.js

Held on #34613

This is a part of #29107. You can look at that issue for more context behind the cleanup process.

Problem

The app has two redundant components:

Old Component: NewDistanceRequestPage
New Component IOURequestStepDistance

Solution

Following the examples (example 1, example 2), the Old Component needs to be completely removed from the codebase

Look at the history of the Old Component
If there are any changes since Nov 27, 2023 which have not been added to the New Component, copy those changes
Replace all uses of the Old Component with the New Component
Remove all traces of Old Component
Be sure to update all routes and navigation to use the new :action param (instead of being hard-coded with "create")
Update any logic like isEditing to use the new action param from the route

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f10eeacf3fc8d218
Upwork Job ID: 1747632624829898752
Last Price Increase: 2024-01-17
Automatic offers:

cubuspl42 | Reviewer | 28115391
DylanDylann | Contributor | 28115392

@johncschuster

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove NewDistanceRequestPage.js and copy any changes since Nov 27 into IOURequestStepDistance.js

What is the root cause of that problem?

Refactoring  of navigation among screens for NewDistanceRequestPage

What changes do you think we should make in order

We will be deleting the component here:

App/src/pages/iou/NewDistanceRequestPage.js

Line 47 in a7a3e7f

function NewDistanceRequestPage({iou, report, route}) {

We will remove the screen from ModalStackNavigators.tsx

I would love to take this!

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove NewDistanceRequestPage.js and copy any changes since Nov 27 into IOURequestStepDistance.js

What is the root cause of that problem?

Remove deprecated component

What changes do you think we should make in order to solve the problem?

Currently, we only use NewDistanceRequestPage in the MoneyRequestSelectorPage but MoneyRequestSelectorPage also be removed in this issue. So that we can remove NewDistanceRequestPage component and all traces like

App/src/libs/Navigation/AppNavigator/ModalStackNavigators.tsx

Line 107 in 278d04e

    
           [SCREENS.MONEY_REQUEST.DISTANCE]: () => require('../../../pages/iou/NewDistanceRequestPage').default as React.ComponentType,

App/src/libs/Navigation/linkingConfig.ts

Line 437 in 278d04e

[SCREENS.MONEY_REQUEST.DISTANCE]: ROUTES.MONEY_REQUEST_DISTANCE.route,

App/src/ROUTES.ts

Lines 293 to 296 in a2f5bd5

    
           MONEY_REQUEST_DISTANCE: { 
        
               route: ':iouType/new/address/:reportID?', 
        
               getRoute: (iouType: string, reportID = '') => `${iouType}/new/address/${reportID}` as const, 
        
           },

App/src/SCREENS.ts

Line 150 in a2f5bd5

DISTANCE: 'Money_Request_Distance',

App/src/libs/Navigation/types.ts

Lines 245 to 248 in a2f5bd5

    
           [SCREENS.MONEY_REQUEST.DISTANCE]: { 
        
               iouType: ValueOf<typeof CONST.IOU.TYPE>; 
        
               reportID: string; 
        
           };

For new component IOURequestStepDistance.

In here

App/src/ROUTES.ts

Lines 347 to 351 in a2f5bd5

    
           MONEY_REQUEST_STEP_DISTANCE: { 
        
               route: 'create/:iouType/distance/:transactionID/:reportID', 
        
               getRoute: (iouType: ValueOf<typeof CONST.IOU.TYPE>, transactionID: string, reportID: string, backTo = '') => 
        
                   getUrlWithBackToParam(`create/${iouType}/distance/${transactionID}/${reportID}`, backTo), 
        
           },

We need to use the new :action param (instead of being hard-coded with "create") like we did here

App/src/ROUTES.ts

Lines 362 to 366 in a2f5bd5

    
           MONEY_REQUEST_STEP_SCAN: { 
        
               route: ':action/:iouType/scan/:transactionID/:reportID', 
        
               getRoute: (action: ValueOf<typeof CONST.IOU.ACTION>, iouType: ValueOf<typeof CONST.IOU.TYPE>, transactionID: string, reportID: string, backTo = '') => 
        
                   getUrlWithBackToParam(`${action}/${iouType}/scan/${transactionID}/${reportID}`, backTo), 
        
           },

Copy changes since 27 Nov to new components based on list commit here: https://github.com/Expensify/App/commits/main/src/pages/iou/NewDistanceRequestPage.js

What alternative solutions did you explore? (Optional)

Job added to Upwork: https://www.upwork.com/jobs/~01f10eeacf3fc8d218

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

I would love to take this!

@eVoloshchak

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

@eVoloshchak

@eVoloshchak reassigning, please take over as C+. If you don't have bandwidth, unassign yourself. Thanks
@DylanDylann can you please post an update on where we're at and what @eVoloshchak needs to help with?

@mallenexpensify

@mallenexpensify Everything is done here, waiting for payment

@DylanDylann

Thanks @DylanDylann , removed Reviewing, added Awaiting Payment and updated the title to reflect payment date.

@DylanDylann

Contributor: @DylanDylann paid $250 via Upwork
Contributor+: @cubuspl42 paid $250 via Upwork

Doesn't look like this needs a regression test created, comment if anyone disagrees.

Navigation Menu

Repository navigation

[Pay 4/29][$250] Remove NewDistanceRequestPage.js and copy any changes since Nov 27 into IOURequestStepDistance.js #34610

Problem

Solution

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

67 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	MONEY_REQUEST_DISTANCE: {
	route: ':iouType/new/address/:reportID?',
	getRoute: (iouType: string, reportID = '') => `${iouType}/new/address/${reportID}` as const,
	},

	[SCREENS.MONEY_REQUEST.DISTANCE]: {
	iouType: ValueOf<typeof CONST.IOU.TYPE>;
	reportID: string;
	};

	MONEY_REQUEST_STEP_DISTANCE: {
	route: 'create/:iouType/distance/:transactionID/:reportID',
	getRoute: (iouType: ValueOf<typeof CONST.IOU.TYPE>, transactionID: string, reportID: string, backTo = '') =>
	getUrlWithBackToParam(`create/${iouType}/distance/${transactionID}/${reportID}`, backTo),
	},

	MONEY_REQUEST_STEP_SCAN: {
	route: ':action/:iouType/scan/:transactionID/:reportID',
	getRoute: (action: ValueOf<typeof CONST.IOU.ACTION>, iouType: ValueOf<typeof CONST.IOU.TYPE>, transactionID: string, reportID: string, backTo = '') =>
	getUrlWithBackToParam(`${action}/${iouType}/scan/${transactionID}/${reportID}`, backTo),
	},

[Pay 4/29][$250] Remove NewDistanceRequestPage.js and copy any changes since Nov 27 into IOURequestStepDistance.js #34610

Description

Problem

Solution

Activity

melvin-bot commented on Jan 16, 2024

KrAbhas commented on Jan 16, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order

njmulsqb commented on Jan 17, 2024

DylanDylann commented on Jan 17, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Jan 17, 2024

melvin-bot commented on Jan 17, 2024

MahmudjonToraqulov commented on Jan 17, 2024

67 remaining items

melvin-bot commented on Apr 24, 2024

mallenexpensify commented on Apr 24, 2024

DylanDylann commented on Apr 24, 2024

mallenexpensify commented on Apr 25, 2024

mallenexpensify commented on May 3, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions