[HOLD for payment 2024-02-19] [$250] Remove MoneyRequestDescriptionPage.js and copy any changes since Nov 27 into IOURequestStepDescription.js

This is a part of #29107. You can look at that issue for more context behind the cleanup process.

Problem

The app has two redundant components:

Old Component: MoneyRequestDescriptionPage
New Component IOURequestStepDescription

Solution

Following the examples (example 1, example 2), the Old Component needs to be completely removed from the codebase

Look at the history of the Old Component
If there are any changes since Nov 27, 2023 which have not been added to the New Component, copy those changes
Replace all uses of the Old Component with the New Component
Remove all traces of Old Component
Be sure to update all routes and navigation to use the new :action param (instead of being hard-coded with "create")
Update any logic like isEditing to use the new action param from the route

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~019b522902265a76e3
Upwork Job ID: 1747632811433705472
Last Price Increase: 2024-01-24
Automatic offers:

s77rt | Reviewer | 28120097
DylanDylann | Contributor | 28120098

@alexpensify

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove MoneyRequestDescriptionPage.js and copy any changes since Nov 27 into IOURequestStepDescription.js

What is the root cause of that problem?

Cleanup  of navigation among screens for MoneyRequestDescriptionPage

What changes do you think we should make in order

We will be deleting the component here:

App/src/pages/iou/MoneyRequestDescriptionPage.js

Line 57 in a7a3e7f

function MoneyRequestDescriptionPage({iou, route, selectedTab}) {

We will remove the screen from ModalStackNavigators.tsx

I would love to take this!

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove MoneyRequestDescriptionPage.js and copy any changes since Nov 27 into IOURequestStepDescription.js

What is the root cause of that problem?

Remove deprecated component

What changes do you think we should make in order to solve the problem?

Remove MoneyRequestDescriptionPage component and all traces like

App/src/libs/Navigation/AppNavigator/ModalStackNavigators.tsx

Line 99 in 278d04e

    
           [SCREENS.MONEY_REQUEST.DESCRIPTION]: () => require('../../../pages/iou/MoneyRequestDescriptionPage').default as React.ComponentType,

App/src/libs/Navigation/linkingConfig.ts

Line 432 in 278d04e

[SCREENS.MONEY_REQUEST.DESCRIPTION]: ROUTES.MONEY_REQUEST_DESCRIPTION.route,

App/src/ROUTES.ts

Lines 273 to 276 in a2f5bd5

    
           MONEY_REQUEST_DESCRIPTION: { 
        
               route: ':iouType/new/description/:reportID?', 
        
               getRoute: (iouType: string, reportID = '') => `${iouType}/new/description/${reportID}` as const, 
        
           },

App/src/SCREENS.ts

Line 144 in a2f5bd5

DESCRIPTION: 'Money_Request_Description',

App/src/libs/Navigation/types.ts

Lines 204 to 209 in a2f5bd5

    
           [SCREENS.MONEY_REQUEST.DESCRIPTION]: { 
        
               iouType: string; 
        
               reportID: string; 
        
               field: string; 
        
               threadReportID: string; 
        
           };

For new component IOURequestStepDescription
In here

App/src/ROUTES.ts

Lines 342 to 346 in a2f5bd5

    
           MONEY_REQUEST_STEP_DESCRIPTION: { 
        
               route: 'create/:iouType/description/:transactionID/:reportID', 
        
               getRoute: (iouType: ValueOf<typeof CONST.IOU.TYPE>, transactionID: string, reportID: string, backTo = '') => 
        
                   getUrlWithBackToParam(`create/${iouType}/description/${transactionID}/${reportID}`, backTo), 
        
           },

We need to use the new :action param (instead of being hard-coded with "create") like

MONEY_REQUEST_STEP_DESCRIPTION: { 
     route: ':action/:iouType/description/:transactionID/:reportID', 
     getRoute: (action: ValueOf<typeof CONST.IOU.ACTION>, iouType: ValueOf<typeof CONST.IOU.TYPE>, transactionID: string, reportID: string, backTo = '') => 
         getUrlWithBackToParam(`${action}/${iouType}/description/${transactionID}/${reportID}`, backTo), 
 },

And then we will create new variable
const isDraft = action === CONST.IOU.ACTION.CREATE (we will get action from route) and pass it to setMoneyRequestDescription_temporaryForRefactor as a new param. In setMoneyRequestDescription_temporaryForRefactor we will save the new description to draft_transaction if isDraft is true else we will save it to the transaction

We also need to remove EditRequestDescriptionPage and we need to update the route to navigate to IOURequestStepDescription (with action = edit) instead of EditRequestDescriptionPage
In here

App/src/components/ReportActionItem/MoneyRequestView.js

Line 289 in d8fb3f4

onPress={() => Navigation.navigate(ROUTES.EDIT_REQUEST.getRoute(report.reportID, CONST.EDIT_REQUEST_FIELD.DESCRIPTION))}

Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_DESCRIPTION.getRoute(CONST.IOU.ACTION.EDIT, iouType, transaction.transactionID, reportID, Navigation.getActiveRouteWithoutParams()));

We also need to update

App/src/components/MoneyTemporaryForRefactorRequestConfirmationList.js

Line 698 in d8fb3f4

    
           Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_DESCRIPTION.getRoute(iouType, transaction.transactionID, reportID, Navigation.getActiveRouteWithoutParams()));

Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_DESCRIPTION.getRoute(CONST.IOU.ACTION.CREATE, iouType, transaction.transactionID, reportID, Navigation.getActiveRouteWithoutParams()));

In editing split flow, we also need to update to navigate to IOURequestStepDescription

App/src/components/MoneyRequestConfirmationList.js

Line 667 in cc71f70

    
           Navigation.navigate(ROUTES.EDIT_SPLIT_BILL.getRoute(props.reportID, props.reportActionID, CONST.EDIT_REQUEST_FIELD.DESCRIPTION));

Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_DESCRIPTION.getRoute(CONST.IOU.ACTION.EDIT, props.iouType, transaction.transactionID, props.reportID, Navigation.getActiveRouteWithoutParams()));

Copy changes since 27 Nov to new components based on list commit here: https://github.com/Expensify/App/commits/main/src/pages/iou/MoneyRequestDescriptionPage.js

What alternative solutions did you explore? (Optional)

Job added to Upwork: https://www.upwork.com/jobs/~019b522902265a76e3

@s77rt

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

Checklist ^ does not apply here. This is a feature request (code refactor) and not a bug.

Flagging that I will be OOO on Monday, but will complete the payment process on Tuesday, February 20.

Payment summary is here: #34609 (comment)

Everyone has been paid via Upwork.

@alexpensify

@alexpensify Payment here should be $125 for the regression. I have refunded $125

Thanks for your honesty! I missed the regression notice and saw it after I hit send in Upwork. All actions are complete here, closing!

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@s77rt

@s77rt - I believe that the regression was already addressed in another GH. Was today's notice an error? Thanks!

Yes the above notice is a false positive

Thanks!

Let's ignore it. It is only a reference

Navigation Menu

Repository navigation

[HOLD for payment 2024-02-19] [$250] Remove MoneyRequestDescriptionPage.js and copy any changes since Nov 27 into IOURequestStepDescription.js #34609

Problem

Solution

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

50 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	MONEY_REQUEST_DESCRIPTION: {
	route: ':iouType/new/description/:reportID?',
	getRoute: (iouType: string, reportID = '') => `${iouType}/new/description/${reportID}` as const,
	},

	[SCREENS.MONEY_REQUEST.DESCRIPTION]: {
	iouType: string;
	reportID: string;
	field: string;
	threadReportID: string;
	};

	MONEY_REQUEST_STEP_DESCRIPTION: {
	route: 'create/:iouType/description/:transactionID/:reportID',
	getRoute: (iouType: ValueOf<typeof CONST.IOU.TYPE>, transactionID: string, reportID: string, backTo = '') =>
	getUrlWithBackToParam(`create/${iouType}/description/${transactionID}/${reportID}`, backTo),
	},

[HOLD for payment 2024-02-19] [$250] Remove MoneyRequestDescriptionPage.js and copy any changes since Nov 27 into IOURequestStepDescription.js #34609

Description

Problem

Solution

Activity

melvin-bot commented on Jan 16, 2024

KrAbhas commented on Jan 16, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order

njmulsqb commented on Jan 17, 2024

DylanDylann commented on Jan 17, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Jan 17, 2024

melvin-bot commented on Jan 17, 2024

50 remaining items

s77rt commented on Feb 13, 2024

alexpensify commented on Feb 15, 2024

alexpensify commented on Feb 20, 2024

s77rt commented on Feb 20, 2024

alexpensify commented on Feb 20, 2024

melvin-bot commented on Mar 11, 2024

alexpensify commented on Mar 11, 2024

s77rt commented on Mar 11, 2024

alexpensify commented on Mar 11, 2024

DylanDylann commented on Mar 11, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions