[HOLD for payment 2024-02-19] [$500] IOU -Deleting submitted report shows unexpected error with amount crossed out

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.25
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Launch app
Login employee account
Tap on employee workspace chat
Tap plus icon near compose-- request money manual
Enter an amount and tap next
Enter merchant field
Tap request
Tap submit
Open submitted IOU to open IOU detail page
Tap 3 dots on top right and tap delete and confirm delete request

Expected Result:

User must not be shown option/allowed to delete submitted report & error should not be displayed with amount crossed out

Actual Result:

In employee WS, create manual request and submit it. User shown option/allowed to delete submitted report and deleted report shows unexpected error with amount crossed out

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6343590_1705353673385.rep.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0165e8908305facf78
Upwork Job ID: 1747014776873512960
Last Price Increase: 2024-01-22
Automatic offers:

s77rt | Reviewer | 28134406
bernhardoj | Contributor | 28134407

Job added to Upwork: https://www.upwork.com/jobs/~0165e8908305facf78

@sakluger

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@0xmiroslav

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

Deleting a submitted money request gives an error.

What is the root cause of that problem?

We are not hiding the delete button when the money request is submitted. We only hide it if it's approved or settled.

App/src/components/MoneyRequestHeader.js

Line 88 in 8e2fb67

    
           const canModifyRequest = isActionOwner && !isSettled && !isApproved && !ReportActionsUtils.isDeletedAction(parentReportAction);

What changes do you think we should make in order to solve the problem?

We need to hide it if the money request is submitted. To know whether it's submitted or not, we can use the same check-in #32796, specifically:

App/src/libs/ReportUtils.ts

Lines 3815 to 3818 in 8e2fb67

    
           const isOwnExpenseReport = isExpenseReport(report) && isOwnPolicyExpenseChat; 
        
           if (isOwnExpenseReport && PolicyUtils.isPaidGroupPolicy(policy)) { 
        
               return isDraftExpenseReport(report); 
        
           }

We only check the submitted status (isDraftExpenseReport true means open, not submitted) in an expense report that is linked with a paid policy.

We need to apply this check in both MoneyRequestHeader and in ReportUtils.canDeleteReportAction.

App/src/libs/ReportUtils.ts

Lines 1139 to 1141 in 8e2fb67

    
           if (isActionOwner) { 
        
               return true; 
        
           }

if (isActionOwner) {
    if (isExpenseReport(report) && PolicyUtils.isPaidGroupPolicy(policy)) {
        return isDraftExpenseReport(report);
    }
    return true;
}

App/src/components/MoneyRequestHeader.js

Lines 115 to 119 in 8e2fb67

    
           threeDotsMenuItems.push({ 
        
               icon: Expensicons.Trashcan, 
        
               text: translate('reportActionContextMenu.deleteAction', {action: parentReportAction}), 
        
               onSelected: () => setIsDeleteModalVisible(true), 
        
           });

if (ReportUtils.isExpenseReport(moneyRequestReport) && PolicyUtils.isPaidGroupPolicy(policy)) {
    if (ReportUtils.isDraftExpenseReport(moneyRequestReport)) {
        threeDotsMenuItems.push({
            icon: Expensicons.Trashcan,
            text: translate('reportActionContextMenu.deleteAction', {action: parentReportAction}),
            onSelected: () => setIsDeleteModalVisible(true),
        });
    }
} else {
    threeDotsMenuItems.push({
        icon: Expensicons.Trashcan,
        text: translate('reportActionContextMenu.deleteAction', {action: parentReportAction}),
        onSelected: () => setIsDeleteModalVisible(true),
    });
}

@sakluger

@sakluger once submitted (but not approved yet), request should not be deletable? I believe so but just to confirm

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

I'm checking on correct expected behavior in Slack: https://expensify.slack.com/archives/C02MW39LT9N/p1706052284329559

Reviewing label has been removed, please complete the "BugZero Checklist".

@s77rt

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.39-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Don't allow employee to delete submitted request #35744

If no regressions arise, payment will be issued on 2024-02-19. 🎊

For reference, here are some details about the assignees on this issue:

@s77rt requires payment automatic offer (Reviewer)
@bernhardoj requires payment automatic offer (Contributor)

@s77rt

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@s77rt] The PR that introduced the bug has been identified. Link to the PR:
[@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@s77rt] Determine if we should create a regression test for this bug.
[@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

The PR that introduced the bug has been identified: This seems to be a bug since day one, Add DeleteMoneyRequest #19095
The offending PR has been commented on: Add DeleteMoneyRequest #19095 (comment)
A discussion in #expensify-bugs has been started: Not needed. More like a onetime bug
Determine if we should create a regression test for this bug: Yes

Regression Test Proposal

Requires a paid workspace e.g. collect workspace

Login as an employee
Create a new money request
Submit the expense report
Go to the money request and Verify you cannot delete it
Login as an admin
Go to the money request and Verify you can delete it

@s77rt

Thanks @s77rt for completing the BZ checklist ahead of time!

Everyone has been paid out. 🙇

Navigation Menu

Repository navigation

[HOLD for payment 2024-02-19] [$500] IOU -Deleting submitted report shows unexpected error with amount crossed out #34538

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

35 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const isOwnExpenseReport = isExpenseReport(report) && isOwnPolicyExpenseChat;
	if (isOwnExpenseReport && PolicyUtils.isPaidGroupPolicy(policy)) {
	return isDraftExpenseReport(report);
	}

	threeDotsMenuItems.push({
	icon: Expensicons.Trashcan,
	text: translate('reportActionContextMenu.deleteAction', {action: parentReportAction}),
	onSelected: () => setIsDeleteModalVisible(true),
	});

[HOLD for payment 2024-02-19] [$500] IOU -Deleting submitted report shows unexpected error with amount crossed out #34538

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jan 15, 2024

melvin-bot commented on Jan 15, 2024

melvin-bot commented on Jan 15, 2024

bernhardoj commented on Jan 16, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

0xmiroslav commented on Jan 18, 2024

melvin-bot commented on Jan 22, 2024

sakluger commented on Jan 23, 2024

35 remaining items

melvin-bot commented on Feb 12, 2024

melvin-bot commented on Feb 12, 2024

melvin-bot commented on Feb 12, 2024

s77rt commented on Feb 13, 2024

sakluger commented on Feb 20, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions