[HOLD for payment 2024-03-13] [Fire Cleanup] Upgrade react-navigation to fix potential crashes

@miljakljajic

TL;DR #fireroom-2024-01-11-ipad-login-crash was caused by a bug in react-navigation.

We have asked Callstack to fix this bug, and they are working on it. This is just a tracking issue to make sure we upgrade E/App's react-navigation version after that bug is fixed.

So for now it's on HOLD for react-navigation/react-navigation#11701

Issue Owner

Current Issue Owner: @miljakljajic

Hi! Its Kuba from Callstack, I will be working on fixing this bug in react navigation.

Great! Let me know how I can help.

@MrRefactor

Officially assigned you @MrRefactor - let me know any updates as you figure things out!

Sure thing!

@MrRefactor

hey @MrRefactor figured I'd check in - how are things going?

@dangrous

Hey @dangrous Im still working on the fix in react-navigation repo

@MrRefactor

@MrRefactor Do you have a rough ETA for the solution? I know these things can be finicky so doesn't have to be exact. Thanks!

@dangrous

Hey @dangrous Im planning to create a PR end of this week or early next week!

Sounds great! Looking forward to it.

@MrRefactor

Hey @MrRefactor checking in - let me know if I can help/review/anything!

@dangrous

Hey @dangrous sorry for the delay but I needed to resolve another issue which was on my plate. Ive been talking to Satya about this one and I will create PR this week which will be approved by him next week.

@dangrous

Hey @dangrous PR is ready and will be check by Satya

@paultsimura

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.47-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Update the version of react-navigation/native #37194

If no regressions arise, payment will be issued on 2024-03-13. 🎊

For reference, here are some details about the assignees on this issue:

@paultsimura requires payment (Needs manual offer from BZ)
@MrRefactor does not require payment (Contractor)

@paultsimura

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@paultsimura] The PR that introduced the bug has been identified. Link to the PR:
[@paultsimura] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@paultsimura] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@paultsimura] Determine if we should create a regression test for this bug.
[@paultsimura] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@miljakljajic

@miljakljajic looks like this shuold be ready to pay out.

@paultsimura please complete the BZ checklist above

@paultsimura

Payment Summary

Upwork Job

ROLE: @paultsimura paid $(AMOUNT) via Upwork (LINK)
Contributor: @MrRefactor is from an agency-contributor and not due payment

BugZero Checklist (@miljakljajic)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

It's a cleanup dependency version bump, not fixing a specific bug.

~~The PR that introduced the bug has been identified. Link to the PR:~~
~~The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:~~
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug: No

@roryabraham

@roryabraham Milja is OOO for the last couple of days. Could we reassign BZ for payment, or better wait?

Paying now!

I'm not seeing an Upwork job for this one - is it a standard 500 USD payment?

yep, standard $500 payout for the C+ review of react-navigation upgrade

@paultsimura

Thank you! @paultsimura - contract sent :)

Navigation Menu

Repository navigation

[HOLD for payment 2024-03-13] [Fire Cleanup] Upgrade react-navigation to fix potential crashes #34523

31 remaining items

Payment Summary

BugZero Checklist (@miljakljajic)

It's a cleanup dependency version bump, not fixing a specific bug.

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-03-13] [Fire Cleanup] Upgrade react-navigation to fix potential crashes #34523

Description

Activity

MrRefactor commented on Jan 15, 2024

dangrous commented on Jan 16, 2024

dangrous commented on Jan 18, 2024

MrRefactor commented on Jan 18, 2024

dangrous commented on Jan 25, 2024

MrRefactor commented on Jan 26, 2024

dangrous commented on Feb 2, 2024

MrRefactor commented on Feb 6, 2024

dangrous commented on Feb 6, 2024

dangrous commented on Feb 13, 2024

MrRefactor commented on Feb 14, 2024

MrRefactor commented on Feb 15, 2024

31 remaining items

melvin-bot commented on Mar 6, 2024

melvin-bot commented on Mar 6, 2024

roryabraham commented on Mar 13, 2024

melvin-bot commented on Mar 13, 2024

Payment Summary

BugZero Checklist (@miljakljajic)

paultsimura commented on Mar 14, 2024

It's a cleanup dependency version bump, not fixing a specific bug.

paultsimura commented on Mar 15, 2024

miljakljajic commented on Mar 18, 2024

miljakljajic commented on Mar 18, 2024

roryabraham commented on Mar 18, 2024

miljakljajic commented on Mar 18, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions