Skip to content

[HOLD for payment 2024-08-02] [Wave Collect] [Ideal Nav] Improve "Hmm... it's not there" being duplicated across two content areas #34234

Description

@trjExpensify

Coming from here.

Problem
With the new ideal navigation layout, we'll run into an instance where the "page not found" illustration is duplicated across two content areas on web/desktop. For example, when you try to access a workspace that has been deleted via a URL link to its settings:

Screenshot 2024-01-09 at 9 44 53 PM

Solution
Instead of showing it twice, we'll instead:

  • Use a full page instead
  • Clicking the back caret brings you back to the screen which you were at when you tried to access the missing workspace.
  • If you don’t have a previous screen to return to, we return to the Chats tab of the “All” view.

image

CC: @hayata-suenaga @mountiny @shawnborton @JmillsExpensify @kosmydel @adamgrzybowski @s77rt

Issue OwnerCurrent Issue Owner: @trjExpensify

Activity

  1. melvin-bot commented on Jan 10, 2024

    @melvin-bot

    Triggered auto assignment to @shawnborton (Design), see these Stack Overflow questions for more details.

  2. melvin-bot commented on Jan 10, 2024

    @melvin-bot
  3. hayata-suenaga commented on Jan 10, 2024

    @hayata-suenaga
    Contributor

    looking at the discussion in the linked Slack thread

  4. shawnborton commented on Jan 10, 2024

    @shawnborton
    Contributor

    This is what it looks like at full screen btw:
    image

  5. kosmydel commented on Jan 15, 2024

    @kosmydel
    Contributor

    Hey, here is a preview of what it looks like.

    Screenshot 2024-01-15 at 10 20 59
  6. shawnborton commented on Jan 15, 2024

    @shawnborton
    Contributor

    That seems good to me!

  7. 60 remaining items

  8. situchan commented on Aug 5, 2024

    @situchan
    Contributor

    Please assign me here

  9. trjExpensify commented on Aug 5, 2024

    @trjExpensify
    ContributorAuthor

    Payment summary as follows:

    Offer sent.

  10. situchan commented on Aug 5, 2024

    @situchan
    Contributor

    Can this be 500?

    reasoning:

    • super old issue (before price change)
    • size of PR which fixes multiple issues at once
    • required lots of testing as seen in QA Steps of PR
  11. trjExpensify commented on Aug 9, 2024

    @trjExpensify
    ContributorAuthor

    super old issue (before price change)

    Fair. Can you accept the offer so I can pay it though?

  12. melvin-bot commented on Aug 12, 2024

    @melvin-bot

    @shawnborton, @trjExpensify, @Gonals, @kosmydel, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

  13. trjExpensify commented on Aug 12, 2024

    @trjExpensify
    ContributorAuthor

    Paid, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2DesignNewFeatureSomething to build that is a new item.

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions