Workspace - Room visibility options are also displayed as tooltips

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.23.0
Reproducible in staging?: Y
Reproducible in production?: No. new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #33808

Action Performed:

Create a workspace
Navigate to FAB - Start chat - Room
Click on the Visibility button
Hover over each title and text

Expected Result:

They shouldn't appear as tooltips

Actual Result:

Room visibility options are also displayed as tooltips

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6336789_1704813307346.bandicam_2024-01-09_13-50-58-037.1.mp4

View all open jobs on GitHub

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@Julesssss

Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

This is not a blocker. Same behaviour on production as well

Screen.Recording.2024-01-09.at.9.18.09.PM.mov

Proposal

Please re-state the problem we are trying to solve

There should be no tooltip for items like pure text in ValuePicker

Root cause

The root cause is that for every item in SelectionList, we display the tooltip as long as it's index is less than 10.

App/src/components/SelectionList/BaseSelectionList.js

Lines 304 to 305 in e9f27ab

    
           // We only create tooltips for the first 10 users or so since some reports have hundreds of users, causing performance to degrade. 
        
           const showTooltip = normalizedIndex < 10;

What changes should be made to fix this?

We should add a prop to the SelectionList whether to show tooltips or not like shouldShowTooltip. Then we can disable the tooltip show prop in the ValueSelectorModal so that tooltip is hidden for value pickers.

Alternate solution

We can also add a shouldShowTooltip to the individual item itself so that we can get even greater control over which item to show tooltip and which not to (but I don't think such control is needed)

Can confirm the above. Also, showing additional tooltips bad enough to block the deploy.

We should still fix

Proposal

Please re-state the problem that we are trying to solve in this issue.

Room visibility options are also displayed as tooltips

What is the root cause of that problem?

We show the tooltip for 10 first items of seclection list

What changes do you think we should make in order to solve the problem?

#33580 in this PR, we're handling to remove the tooltip in the timezone page.

We can handle this case as well in this PR
Wait this PR is merge and we can use the shouldShowTooltip prop to disable tooltip in the visibility as well.

What alternative solutions did you explore? (Optional)

NA

IMO, #33580 should cover this case as well

IMO, #33580 should cover this case as well

Agree, thank you.

Navigation Menu

Repository navigation

Workspace - Room visibility options are also displayed as tooltips #34156

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem we are trying to solve

Root cause

What changes should be made to fix this?

Alternate solution

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	// We only create tooltips for the first 10 users or so since some reports have hundreds of users, causing performance to degrade.
	const showTooltip = normalizedIndex < 10;

Workspace - Room visibility options are also displayed as tooltips #34156

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

github-actions commented on Jan 9, 2024

melvin-bot commented on Jan 9, 2024

esh-g commented on Jan 9, 2024

esh-g commented on Jan 9, 2024

Proposal

Please re-state the problem we are trying to solve

Root cause

What changes should be made to fix this?

Alternate solution

Julesssss commented on Jan 9, 2024

dukenv0307 commented on Jan 9, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

situchan commented on Jan 9, 2024

Julesssss commented on Jan 9, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions