[HOLD for payment 2024-01-25] [$500] Android&iOS - Expense - Report submission and approval messages are smaller than other text

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.22-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition:

• User is an employee of a Collect workspace on Old Dot
• Device font size is set to minimum

1. Go to workspace chat
2. Create a manual request
3. Click on the preview > Submit
4. As admin, approve the report > Pay elsewhere
5. As employee, go to the paid expense report

Expected Result:

The system message for report submission and approval has the same font size as other text

Actual Result:

The system message for report submission and approval is smaller than other text

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6333462_1704484111434.Screen_Recording_20240105_153346_New_Expensify__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f27180af7e40074d
• Upwork Job ID: 1743370347796152320
• Last Price Increase: 2024-01-05
• Automatic offers:
• jjcoffee | Reviewer | 28092877
• dukenv0307 | Contributor | 28092878

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f27180af7e40074d

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The system message for report submission and approval is smaller than other text

What is the root cause of that problem?

The Text here doesn't use our custom Text component from @components/Text so it doesn't have proper font scaling handling like other texts.

What changes do you think we should make in order to solve the problem?

In here, use our custom Text component from @components/Text, we can consider doing that for all the Text component in that file as well.

What alternative solutions did you explore? (Optional)

We should double check other usage of Text component from react-native because it will have the same issue.

[mallenexpensify]

The Text here doesn't use our custom Text component from @components/Text so it doesn't have proper font scaling handling like other texts.

@dukenv0307 and @jjcoffee , do you know if there are other instances of the wrong size text and/or where @components/Text isn't being referenced? I'm on the fence about fixing this but.. if there are more instances we can address at the same time here, I'm more inclined to push it through.