[HOLD for payment 2024-01-25] [$500] Android - Workspace - 1:1 DM between workspace members duplicated in LHN when invite again

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.21-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Open app
2. Create a workspace
3. Invite any members to the workspace
4. Navigate on LHN
5. Navigate to settings and remove the workspace members that were added
6. Navigate to LHN
7. Navigate to settings and add the previously removed members to the workspace again
8. Navigate to LHN

Expected Result:

Announce, Admins and 1:1 DM conversations with each member should be displayed in LHN

Actual Result:

The workspace 1:1 DM between members becomes duplicated in LHN when deleted members was invited to the workspace again

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6331782_1704328534456.screen-20240104-004759.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ce876b8941cda7d5
• Upwork Job ID: 1742714691943944192
• Last Price Increase: 2024-01-04
• Automatic offers:
• dukenv0307 | Contributor | 28089947

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ce876b8941cda7d5

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The workspace 1:1 DM between members becomes duplicated in LHN when deleted members was invited to the workspace again

What is the root cause of that problem?

Typo in

App/src/libs/ReportUtils.ts

Line 3501 in 4b9b55e

const sortedParticipanctsAccountIDs = report.parentReportActionIDs?.sort();

We're getting the participant ids from the parentReportActionIDs field, which is incorrect, this leads to unabling to find the existing workspace chat of that invited member, and a new chat is created.

This is introduced by this TS migration PR

What changes do you think we should make in order to solve the problem?

In

App/src/libs/ReportUtils.ts

Line 3501 in 4b9b55e

const sortedParticipanctsAccountIDs = report.parentReportActionIDs?.sort();

Change parentReportActionIDs to participantAccountIDs

What alternative solutions did you explore? (Optional)

NA

[lschurr]

@thesahindia could you review?