Repository navigation
[Payment DUE] [$500] Login - svg background image appears late in login screen #33916
Description
Activity
- changed the title
[-]Android & iOS - Logiin - svg background image appears late in login screen[/-][+][$500] Android & iOS - Logiin - svg background image appears late in login screen[/+]on Jan 4, 2024 Job added to Upwork: https://www.upwork.com/jobs/~0165b8a813aeee9ac5
Triggered auto assignment to @alexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.Bug0 Triage Checklist (Main S/O)
- This "bug" occurs on a supported platform (ensure
Platformsin OP are ✅) - This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
- This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
- This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
- I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
- This "bug" occurs on a supported platform (ensure
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (
External)Proposal
Please re-state the problem that we are trying to solve in this issue.
svg background image appears late in login screen
What is the root cause of that problem?
the loading process of the SVG background image using
expo-imagehas been introduced in this PR
App/src/pages/signin/SignInPageLayout/BackgroundImage/index.ios.js
Lines 25 to 28 in 1da3052
and since this library loads the image first time on request, then takes some time till the image is loaded..
What changes do you think we should make in order to solve the problem?
we have two options:
- we can try to reduce the background svg size .. the following tool https://github.com/svg/svgo reduces the size without losing the image quality as it only removes most of the metadata info .. i have tried it out and it reduced the size of the home-background--mobile-new.svg by 28.7% and thus the loading was faster .. i think it worth considering.
- we can revert using the
expo-imageand use the old way where the image gets preloaded (although i dont think you want to revert it)
@eVoloshchak when you get a chance, can you review this proposal? Thanks!
29 remaining items
📣 @wildan-m 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖@arosiclair, @eVoloshchak thanks for the follow-up, I've created a new PR ready for review.
Awesome, we are moving forward here.
Weekly update: PR is going to staging soon.
@alexpensify seems automation broken for this bug post. The PR deployed to production 3 days ago, but the title did not change
@wildan-m - thanks for flagging, then I'll monitor this one until it hits the seven-day mark. I'll need to do so manually.
- changed the title
[-][$500] Login - svg background image appears late in login screen[/-][+][Payment DUE] [$500] Login - svg background image appears late in login screen[/+]on Feb 12, 2024 Here is the payment summary:
- External issue reporter - N/A
- Contributor that fixed the issue - $500 @wildan-m
- Contributor+ that helped on the issue and/or PR - $500 @eVoloshchak
Upwork Job: https://www.upwork.com/jobs/~0165b8a813aeee9ac5
Extra Notes regarding payment: I have to apply the payment details manually, this PR was merged 7 days ago - #35215.
Reacted by wildan-mActions taken:
- @wildan-m has been paid via Upwork
- @eVoloshchak please submit a request in Chat
- Lastly, I closed the job in Upwork
Closing
$500 approved for @eVoloshchak based on summary above.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.21-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
On login page, the svg background image will not appear late
Actual Result:
On login page, the svg background image appears late
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6331770_1704327642037.Screen_Recording_20240103_165253_New_Expensify__1_.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit